Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should bw_plug link to the new plugin directory? #18

Closed
bobbingwide opened this issue Feb 12, 2017 · 3 comments

Comments

Projects
None yet
1 participant
@bobbingwide
Copy link
Owner

commented Feb 12, 2017

When you visit a plugin on WordPress.org using the old style link
you get taken to a page that says "Test out the new Plugin Directory and let us know what you think."

The target URL is only slightly different.

https://wordpress.org/plugins/wordpress-seo/
https://wordpress.org/plugins-wp/wordpress-seo/

Should we be pointing users to the new plugin directory?
What happens when this goes live?

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

commented Sep 25, 2017

Answer: In the example above we should be pointing to https://wordpress.org/plugins/wordpress-seo.
Notes:

  • https rather than http
  • remove /extend from the path

For assets from ps.w.org we haven't yet changed to https

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

commented Jun 13, 2019

Before I close this I've decided to remove the additional link below the banner image when the shortcode is of the form [bw_plug name=plugin banner=?] e.g. [bw_plug name=gutenberg banner=j].
The link in the image points to where the plugin can be found.
e.g. https://wordpress.org/plugins/gutenberg
More often than not the text link below it was to itself.
e.g. https://blocks.wp-a2z.org/oik-plugins/gutenberg/

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

commented Jun 13, 2019

For assets from ps.w.org we haven't yet changed to https

The code has been changed. The PHPUnit tests need to be updated to reflect this change.

bobbingwide added a commit that referenced this issue Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.