Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count action hook and filter invocation for trace summary report #53

Closed
bobbingwide opened this issue Jan 4, 2017 · 4 comments
Closed

Count action hook and filter invocation for trace summary report #53

bobbingwide opened this issue Jan 4, 2017 · 4 comments
Assignees
Labels

Comments

@bobbingwide
Copy link
Owner

@bobbingwide bobbingwide commented Jan 4, 2017

The daily trace summary report may benefit from a simple figure that shows how many action hooks and filters were invoked in the transaction.

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

@bobbingwide bobbingwide commented Jan 10, 2017

Having developed this logic I wanted to test the affect on performance of including this count when oik-bwtrace is not otherwise active. Since I also wanted to attempt to measure the affect of the new hook logic on performance I developed the count-hooks.php routine in wp-top12. See bobbingwide/wp-top12#4

@bobbingwide bobbingwide self-assigned this Jan 10, 2017
@bobbingwide

This comment has been minimized.

Copy link
Owner Author

@bobbingwide bobbingwide commented Nov 30, 2019

We have to consider the value of this information with respect to the time taken to measure it.
Table assumes that the Daily Trace Summary report is being produced

Tracing Count hooks what’s there to show?
n n Nothing - not needed - output null
N y Nothing - we’d need to use our own counting hook
Y n Nothing - not needed - output null
Y y field should be set! We’ve been tracing anyway

In the second case, we’d need to develop a separate counting hook for the daily trace summary. It would be easy to measure the affect on performance by looking at the summary report.
I think it’s worthwhile doing as an experiment.

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

@bobbingwide bobbingwide commented Nov 30, 2019

Having added a very simple hook, I think it would be nice to include the 'Hook count' figure in each trace record, after the cf=current filter string. If hook counting isn't selected then no value would be shown.

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

@bobbingwide bobbingwide commented Dec 5, 2019

That last commit should have been for #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.