New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WordPress 5.0 and the new editor - Gutenberg #13

Open
bobbingwide opened this Issue Feb 2, 2018 · 4 comments

Comments

Projects
None yet
1 participant
@bobbingwide
Copy link
Owner

bobbingwide commented Feb 2, 2018

Since early 2017 a new editor has been under development. Code named Gutenberg this new editor is being developed as a feature plugin. It is expected to be merged into core for WordPress 5.0.

We need to be aware of Gutenberg and to attempt to be compatible with it.
Actually, it's the other way round. Gutenberg needs to be backward compatible with us.

Area Problem Reference
show_in_rest oik-types does not support show_in_rest See below

@bobbingwide bobbingwide self-assigned this Feb 2, 2018

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

bobbingwide commented Feb 2, 2018

Requirement

Enable a Custom Post Type's registration to be changed to either support show_in_rest or not.
This can be used to control, by post type, which editor gets used.

show_in_rest Default Editor Other editor
Checked New Visual / Code editor Classic Visual / Text editor
Unchecked Classic Visual / Text editor none

Proposed solution

  • Add Show in rest checkbox to oik-type's admin
@bobbingwide

This comment has been minimized.

Copy link
Owner Author

bobbingwide commented Feb 6, 2018

This applies to custom taxonomies as well.

bobbingwide added a commit that referenced this issue Mar 14, 2018

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

bobbingwide commented Mar 16, 2018

The show_in_rest option is a useful field to display in the post type list. We can consider combining the information gathered for the [content] shortcode, being developed for oik-block, into the summary displays for oik-types.

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

bobbingwide commented Mar 27, 2018

Note: If the post type has show_in_rest true but custom taxonomies are show_in_rest false then
Gutenberg will not display the custom taxonomies. It gets a 403 error. This is a backwards compatibility problem.

There is another situation where Gutenberg crashes when trying to load the custom taxonomies, due to a 404 being returned on the REST request.
I don't know if this has been raised as a Gutenberg issue. It's not that easily repeatable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment