Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer the [bwtrace], [bwtron] and [bwtroff] shortcodes to oik-bwtrace #105

Closed
bobbingwide opened this issue Apr 24, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@bobbingwide
Copy link
Owner

commented Apr 24, 2018

Many versions ago the oik-bwtrace plugin was a separately activatable component of the oik base plugin. When it was split out to its own separate plugin, the logic to register and invoke the three trace related shortcodes remained in the oik base plugin. This was primarily because the shortcode functions depend upon oik's base logic. Now that a lot of this logic is available as shared library functions we should be able to migrate the shortcodes to the oik-bwtrace plugin.

Requirement

  • Transfer the following shortcodes from oik to oik-bwtrace: [bwtrace], [bwtron], [bwtroff]
  • Ensure oik-bwtrace operates correctly without oik
  • Extend the shortcodes to cater for the different types of tracing: browser, ajax, rest, cli
  • No longer use the images/oik-trace_48.png file for the link to the Trace options page.

Proposed solution

Initial investigation: pre-removal from oik

  • The shortcodes/oik-trace.php file should operate like a shared library
  • Copy it to oik-bwtrace
  • Register the shortcodes with a higher priority, i.e. later than oik, in response to the oik_add_shortcodes action hook.
@bobbingwide

This comment has been minimized.

Copy link
Owner Author

commented May 25, 2018

Final solution: removal from oik

  • Do not register the shortcodes in oik; bwtron, bwtroff and bwtrace.
  • Move the PHPUnit tests for the trace shortcodes to oik-bwtrace, including the tests/data files
  • Retain the default help for backward compatibility.
@bobbingwide

This comment has been minimized.

Copy link
Owner Author

commented May 16, 2019

  • Retain the default help for backward compatibility.
    Decided not to do this after all. oik bwtrace no longer supports those view and reset actions since they don't make sense when there can be multiple trace output files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.