New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PayPal buttons not working #123

Open
bobbingwide opened this Issue Feb 9, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@bobbingwide
Copy link
Owner

bobbingwide commented Feb 9, 2019

It was reported by my wife that her PayPal buttons were not working.

Expected output

PayPal payment made

Actual output

PayPal produces a message indicating a problem.

Initial investigation

There appears to be a problem setting the email address in the hidden business input field submitted to PayPal.
The donate button on the oik options page appears to work though.

@bobbingwide bobbingwide added the bug label Feb 9, 2019

@bobbingwide bobbingwide self-assigned this Feb 9, 2019

@bobbingwide

This comment has been minimized.

Copy link
Owner Author

bobbingwide commented Feb 9, 2019

There was a typo in a fix many moons ago. 8330386

While the PHPUnit test does execute the path that retrieves the paypal-email from oik options, the test worked because it wasn't right. The expected output is wrong.

With the corrected code, and a stored value for paypal-email, the tests now fail.

I'll release the fix first, then update the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment