Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WordPress 5.2 #130

Open
bobbingwide opened this issue May 8, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@bobbingwide
Copy link
Owner

commented May 8, 2019

Update the oik base plugin so that it works without producing Notices in WordPress 5.2

In WordPress 5.2 the filter login_headertitle filter has been deprecated.
This filter is used in oik_lazy_login_head to replace the WordPress logo image with our own custom image. After updating to WordPress 5.2, when WP_DEBUG is true and a custom logo image is being used, the following message is being produced on the login / logged out page.

User Notice: login_headertitle is <strong>deprecated</strong> since version 5.2.0! 
Use login_headertext instead. 
Usage of the title attribute on the login logo is not recommended for accessibility reasons. 
Use the link text instead.

I think this message is telling me to change the code to use login_headertext.
Having two "Use ... instead" statements is rather confusing, don't you think?

@bobbingwide bobbingwide self-assigned this May 8, 2019

bobbingwide added a commit that referenced this issue May 15, 2019

Issue #130 - use login_headertext rather than login_headertitle - to …
…avoid deprecated notice in WordPress 5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.