New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Enable displaying line numbers all the way down #123

Closed
joelmoniz opened this Issue Jul 7, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@joelmoniz
Copy link
Contributor

joelmoniz commented Jul 7, 2015

Would it be possible to add in a method, (like setAllLineNumbersVisible(boolean)) to allow the user to choose whether or not all the line numbers are visible, even if so many lines have not yet been typed? For example,

setAllLineNumbersVisible(false) would make the line numbers display as:
setAllLineNumbersVisible(false)

while
setAllLineNumbersVisible(true) would get them to display as:
setAllLineNumbersVisible(true)

@bobbylight

This comment has been minimized.

Copy link
Owner

bobbylight commented Jul 19, 2015

I'm not interested in implementing this, and I do not believe it to be common in text editors to do so.

@bobbylight bobbylight closed this Jul 19, 2015

@joelmoniz

This comment has been minimized.

Copy link
Contributor

joelmoniz commented Jul 19, 2015

Ah, I understand. I had brought up this issue, along with #124 and this question I had asked on the forum because I am working on replacing processing's JEditTextArea with the RSyyntaxTextArea, and am trying to mimic the editor's look and feel as closely as possible:

image

Would it be alright if I sent in a PR sometime that takes a crack at implementing this feature (turned off by default, but which the user can enable), or is it not likely to be merged? Thanks!

@bobbylight

This comment has been minimized.

Copy link
Owner

bobbylight commented Jul 25, 2015

Sure, pull requests are welcome. Be sure to consider code folding and line wrap when working on this addition, since they affect the line numbering view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment