New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error marker postion errors in Error Strip #130

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@joelmoniz
Copy link
Contributor

joelmoniz commented Jul 16, 2015

This PR resolves #129. Now, the first marker has been made visible, and the off-by-one-line error fixed.

Original:

image

Now:

fixed_error_tab_position_sml

The fix was just a tiny correction in the lineToY() method. Instead of going from [-2 to height], Y now goes from [0 to height-2], so that both the first and last markers display. line-1 has now been made line to fix the off-by-one error.

@bobbylight

This comment has been minimized.

Copy link
Owner

bobbylight commented Jul 19, 2015

Actually, although this is not document, ParserNotices should return line indexes in the range (1 - lineCount), not (0 - lineCount-1), which I assume you are doing because of this patch. If you do the former, the marked occurrences on the first line are indeed visible.

However, we do cut off the top 2 pixels of marked occurrences on the first line, so I will apply a modified version of your fix to address that (painting in the y-range 0 - (height-2)). Thanks for that.

@joelmoniz joelmoniz deleted the joelmoniz:errorTabOffset branch Jul 19, 2015

@joelmoniz

This comment has been minimized.

Copy link
Contributor

joelmoniz commented Jul 19, 2015

Ah yes, sorry about that. I was indeed using (0 - lineCount-1) as per the TaskTagParser. I've filed a tiny little PR that resolves this at #131.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment