New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new UI and code for 2nd Y axis range. #195

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@TimBailey-pnk
Copy link

TimBailey-pnk commented Jan 28, 2019

Default values to same as 1st Y axis when loading to mimic current behaviour

Add new UI and code for 2nd Y axis range. Default values to same as 1…
…st Y axis when loading to mimic current behaviour
@Frogmore42

This comment has been minimized.

Copy link

Frogmore42 commented Jan 28, 2019

I like it. Just this morning I was trying to view power and voltage on the same graph and wanted to adjust the power max level to get two graphs to match. But, when I did that it also adjusted the max level on the voltage, which made it impossible to read.

While I generally hate excess whitespace and support its removal, it makes it harder to see the actual change. Not sure if @boblemaire has virtual whitespace on or if that is the way the file came from OEM. Bob is going to have to figure out how he wants to handle PRs.

@TimBailey-pnk

This comment has been minimized.

Copy link
Author

TimBailey-pnk commented Jan 28, 2019

Crap, loads of whitespace changes....probably my dev setup affecting that. Will see if I can remove those changes.
At work we use http://EditorConfig.org to try and standardise tabs/spaces etc
and use StandardJs to format javascript files to a known style and "best practice"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment