New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex fix for scriptrun test #4

Merged
merged 1 commit into from Jan 11, 2016

Conversation

Projects
None yet
2 participants
@openstrike
Contributor

openstrike commented Jan 8, 2016

Test 3 in t/event_scriptrun.t was failing because the hostname returned by Sys::Hostname is the FQDN and the dots in there don't match the regex which was just /\w+/ (introduced in commit 3036f81). The new regex matches the dots as well so the test now passes.

I've been assigned this dist as part of the CPAN Pull Request Challenge - thank you for taking part. If there's anything in particular you think requires attention please let me know and I'll look into it.

Regex fix for scriptrun test
The old regex did not match the dots in the FQDN

bobtfish added a commit that referenced this pull request Jan 11, 2016

Merge pull request #4 from openstrike/testfix
Regex fix for scriptrun test

@bobtfish bobtfish merged commit 5d2032c into bobtfish:master Jan 11, 2016

@openstrike openstrike deleted the openstrike:testfix branch Jan 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment