Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISODate bug #130

Closed
Scorpiion opened this issue Aug 11, 2013 · 4 comments
Closed

ISODate bug #130

Scorpiion opened this issue Aug 11, 2013 · 4 comments

Comments

@Scorpiion
Copy link

@Scorpiion Scorpiion commented Aug 11, 2013

Hi, been using Genghisapp for a while now it's really nice I must say!

I have one problem though, ISODate does not really work as expected when I try to edit or create entries. I'm not completely sure if it's only me, but I don't think so.

To recreate, add a document like this:
{
uptime: ISODate("0001-01-01T01:00:00+01:00")
}

And if the bug is not only me, the saved value will become something like this:
{
uptime: ISODate("1901-01-01T01:00:00+01:00")
}

It can fetch and present ISODate("0001-01-01T01:00:00+01:00") just fine if it's already in the database, but it can't add it manually from the interface or edit a document manually.

bobthecow added a commit that referenced this issue Aug 11, 2013
Thirteen years past y2k, and JavaScript is still dumb about years less than 100 :-/

See #130
@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Aug 11, 2013

Arrgh. JavaScript. I bet you thought weren't going to get bitten by a y2k bug in 2013, right?

The branch hotfix/2.3.8 should contain a fix for this. Do you mind testing it?

Funny story: the mongo shell has the same bug, because it's using almost the exact same date handling I was :-/

@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Aug 13, 2013

This has been released in v2.3.8. Thanks for reporting it!

@bobthecow bobthecow closed this Aug 13, 2013
@Scorpiion
Copy link
Author

@Scorpiion Scorpiion commented Aug 13, 2013

Hi, sorry I have not had the time to reply earlier.

Works great with the new release, thanks for the quick fix!

@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Aug 13, 2013

No worries. Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants