New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaced collection names #56

Closed
heruan opened this Issue Nov 14, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@heruan

heruan commented Nov 14, 2012

I have collection names organized in namespaces using dot-notation (as suggested in MongoDB documentation). For example, a collection could be named My.Users.Employees. When using dotted names, actions like deleting a collection in Genghis fail (e.g. when Genghis asks to explicitly write the collection's name to confirm deletion, it doesn't work). It may be just a JavaScript issue, I'm not sure.
A similar behaviour happens when collection names have a backslash character in them (e.g. My\Users\Employees, in PHP namespace notation).

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Nov 14, 2012

Owner

Thanks for reporting this, I'll take a look.

Owner

bobthecow commented Nov 14, 2012

Thanks for reporting this, I'll take a look.

bobthecow added a commit that referenced this issue Nov 15, 2012

Handle nonstandard characters in collection names.
Add API tests for non-standard collection name characters. The PHP backend currently fails for forward slashes in collection names, but passes everything else.

See #56
@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Nov 15, 2012

Owner

I just created a failing test case for this problem. The Ruby backend was fine, but the PHP backend needed help. The test and a fix for PHP are in develop. Note that I haven't fixed forward slashes in collection names yet, but it works for all sorts of other crazy characters now. Feel free to use the develop branch version and let me know if you have any other problems. Otherwise, it'll be in the next release.

Owner

bobthecow commented Nov 15, 2012

I just created a failing test case for this problem. The Ruby backend was fine, but the PHP backend needed help. The test and a fix for PHP are in develop. Note that I haven't fixed forward slashes in collection names yet, but it works for all sorts of other crazy characters now. Feel free to use the develop branch version and let me know if you have any other problems. Otherwise, it'll be in the next release.

@bobthecow

This comment has been minimized.

Show comment
Hide comment
@bobthecow

bobthecow Nov 16, 2012

Owner

Ha! My test case was wrong, forward slashes in URLs works just fine :)

|'m closing this issue, as v2.1.5 was just released. Thanks again for the bug report.

Owner

bobthecow commented Nov 16, 2012

Ha! My test case was wrong, forward slashes in URLs works just fine :)

|'m closing this issue, as v2.1.5 was just released. Thanks again for the bug report.

@bobthecow bobthecow closed this Nov 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment