Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the document creation hotkey to something else #79

Closed
julien-c opened this issue Feb 20, 2013 · 11 comments
Closed

Change the document creation hotkey to something else #79

julien-c opened this issue Feb 20, 2013 · 11 comments

Comments

@julien-c
Copy link

@julien-c julien-c commented Feb 20, 2013

The shortcut for document, collection or database creation (c) conflicts with the OS's copy (which is very natural to use in Genghis too). Could we find another shortcut that would not conflict with anything major?

That would be great!

@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Feb 20, 2013

But it shouldn't be conflicting with cmd+c or ctrl+c... Are you seeing otherwise?

@julien-c
Copy link
Author

@julien-c julien-c commented Feb 20, 2013

Yup, it conflicts with cmd+c on my Mac at least. Which modifier key is it supposed to hook into?

@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Feb 20, 2013

Just c (no modifier). What browser (and version) and OS version are you using?

@julien-c
Copy link
Author

@julien-c julien-c commented Feb 20, 2013

Latest Chrome (it's been doing that ever since I started using Genghis, that's why I was thinking it was intentional), OS X Lion.

You know what, it might be because of the way I press cmd+c (I might press both then release cmd a few ms before c...). So it's probably a bug with my typing. Sorry for the false alert.

@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Feb 20, 2013

Does pressing cmd+c that way reliably copy elsewhere? It's possible that I could swap out my hotkeys library for one that handles keydown/keyup for modifier keys. Right now I think it's just "modifier is pressed when key is released", but if that's not how hotkeys work system wide, I'm open to finding a new hotkeys library :)

@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Feb 20, 2013

If I understand correctly, you're doing:

KeyDown Cmd
KeyDown c
KeyUp   Cmd
KeyUp   c

and I'm doing:

KeyDown Cmd
KeyDown c
KeyUp   c
KeyUp   Cmd

Is that right?

@julien-c
Copy link
Author

@julien-c julien-c commented Feb 20, 2013

I'd need a slo-mo camera to figure out what exactly I am doing, but yes, you're right.

Yes, I've never had a reliability issue with my copy-pasting :) Does your first schema not work on your setup (to copy)?

I just spent a few minutes trying to reprogram my brain to do it your (probably the more frequent) way but I'm having a pretty hard time.

I can investigate hotkeys library if you'd like.

@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Feb 21, 2013

Hokay. Hotkey handling is improved across the board in b66e426 ... I've tested it with your weird sequence, and it seems to perform as expected :)

That's available in the dev branch. Mind checking it out and making sure it works for you?

@julien-c
Copy link
Author

@julien-c julien-c commented Feb 21, 2013

It does work flawlessly. Justin, you're a personal hero of mine :)

🍻

@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Feb 21, 2013

Sweet!

The new version should be released today. I'm just tidying up a few loose ends.

@bobthecow bobthecow closed this in b66e426 Feb 21, 2013
@bobthecow
Copy link
Owner

@bobthecow bobthecow commented Feb 21, 2013

And done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.