Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree builder without a root node deprecation in Symfony/Config 4.2+ #2

Merged
merged 2 commits into from
Jan 9, 2019

Conversation

BeyerJC
Copy link
Contributor

@BeyerJC BeyerJC commented Jan 7, 2019

Fixes issue #1

Copy link
Owner

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @WhiteRabbitDE ,

Thank you for this PR! But you know what? Now I see we don't use $rootNode at all :) So, I think we should whether remove it and keep only something like this:

         $treeBuilder = new TreeBuilder('bw_active_menu_item');

         return $treeBuilder;

Or keep your legacy fix but let's comment it out then, since we don't use it anyway. Wdyt?

@BeyerJC
Copy link
Contributor Author

BeyerJC commented Jan 8, 2019

Hi @bocharsky-bw,
I'm totally with you! I saw that there is no configuration processed but was afraid to just remove it on my own without talking to you first :-)
Imho we could remove the whole part since its very unlike that it will be used someday.

Tldr : I like your solution and could update the PR If you agree.

@bocharsky-bw
Copy link
Owner

Yeah, much better, thank you! 👍

@bocharsky-bw bocharsky-bw merged commit 7330a57 into bocharsky-bw:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants