New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades Rails version and adds some authorization related to expenses #18

Merged
merged 5 commits into from Nov 1, 2015

Conversation

Projects
None yet
2 participants
@boddhisattva
Owner

boddhisattva commented Nov 1, 2015

Change include -

  1. Upgrade to Rails 4.2.4
  2. Ensures that a user can edit, update and destroy only their expenses

boddhisattva added some commits Nov 1, 2015

Upgrades to the latest stable rails version
There were some security vulnerabilities as part of Rails 4.2.0 and
they were fixed as part of Rails 4.2.2(one can find more details about
these vulnerabilities on
http://weblog.rubyonrails.org/2015/6/16/Rails-3-2-22-4-1-11-and-4-2-2-ha
ve-been-released-and-more/). As of this date the latest stable version
of Rails is 4.2.4, this commit upgrades to the latest stable version of
Rails.
Modifies the spec description to make it more accurate
The spec mainly tests if the appropriate flash message is displayed. It
is not concerned if this message is displayed on redirect or otherwise.
@@ -69,4 +67,11 @@ def dates_are_present?(from_date, to_date)
@date_validator.to_date = Date.parse(to_date) if to_date.present?
@date_validator.valid?
end
def authorize_user

This comment has been minimized.

@houndci-bot

houndci-bot Nov 1, 2015

Inconsistent indentation detected.

@houndci-bot

houndci-bot Nov 1, 2015

Inconsistent indentation detected.

boddhisattva added a commit that referenced this pull request Nov 1, 2015

Merge pull request #18 from boddhisattva/code-cleanup
Upgrades Rails version and adds some authorization related to expenses

@boddhisattva boddhisattva merged commit e0fe469 into master Nov 1, 2015

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound 1 violation found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment