New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filling in layout #2

Merged
merged 18 commits into from Oct 18, 2015

Conversation

Projects
None yet
2 participants
@boddhisattva
Owner

boddhisattva commented Oct 18, 2015

Changes include:

  1. Added Bootstrap
  2. Added Custom CSS
  3. Added a contact page
  4. Added a footer for the website
  5. Added some ruby cops to override some of the hound defaults
Show outdated Hide outdated config/routes.rb
Show outdated Hide outdated config/routes.rb
Show outdated Hide outdated config/routes.rb
Show outdated Hide outdated config/routes.rb
line-height: 1;
}
h1 {

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

h1, h2, h3, h4, h5, h6 {
line-height: 1;
}

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

h1, h2, h3, h4, h5, h6 {
line-height: 1;
}

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

/* typography */
h1, h2, h3, h4, h5, h6 {
line-height: 1;

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

/* typography */
h1, h2, h3, h4, h5, h6 {

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

@houndci-bot

houndci-bot Oct 18, 2015

Each selector in a comma sequence should be on its own line

/* header */
#logo {

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Avoid using id selectors

@houndci-bot

houndci-bot Oct 18, 2015

Avoid using id selectors

boddhisattva added some commits Oct 18, 2015

overrides the default hound related max line length
  - Sets the new default max line length check to be 120 characters
float: right;
list-style: none;
li {

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Selector should have depth of applicability no greater than 2, but was 3

@houndci-bot

houndci-bot Oct 18, 2015

Selector should have depth of applicability no greater than 2, but was 3

}
/* header */

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

}
}
/* typography */

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

@import "bootstrap-sprockets";
@import "bootstrap";
/* mixins, variables, etc. */

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

}
/* footer */

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

$gray-medium-light: #eaeaea;
$white: #ffffff;
/* universal */

This comment has been minimized.

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

@houndci-bot

houndci-bot Oct 18, 2015

Use // comments everywhere

boddhisattva added a commit that referenced this pull request Oct 18, 2015

@boddhisattva boddhisattva merged commit ccd407c into master Oct 18, 2015

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound 12 violations found.

@boddhisattva boddhisattva deleted the filling-in-layout branch Nov 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment