Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow HTML class to be specified for each column in the report. #50

Merged
merged 1 commit into from Dec 8, 2012

Conversation

Projects
None yet
2 participants
Collaborator

mipearson commented Dec 6, 2012

We're bad and occasionally use non-semantic CSS classes. Eg, I've used this patch to specify :class => 'nowrap' on many of the report columns.

I couldn't find a spec for datagrid_column_classes. If there is one, and I've missed it, let me know and I'll write a test.

Also as you use a wiki rather than putting the documentation in the source I have not included a documentation update.

Owner

bogdan commented Dec 7, 2012

Can we allow to specify all set of HTML attributes with :html option, like column(:id, :html => {:class => "nowrap", :something => "else"}?

I believe this is more flexible.

Please include a unit test for this.

Collaborator

mipearson commented Dec 7, 2012

Won't this conflict with the existing :html => true option?

Owner

bogdan commented Dec 7, 2012

Hm, true.

Let it be only class now.

Please add a test.

Collaborator

mipearson commented Dec 8, 2012

Test added.

bogdan added a commit that referenced this pull request Dec 8, 2012

Merge pull request #50 from bikeexchange/allow_class_per_column
Allow HTML class to be specified for each column in the report.

@bogdan bogdan merged commit 39f8048 into bogdan:master Dec 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment