From e40a182630adeafac9543617f6e63bf8013c0b7c Mon Sep 17 00:00:00 2001 From: Jason Ginchereau Date: Wed, 22 Mar 2017 16:18:00 -0700 Subject: [PATCH] Use size_t where appropriate (#181) --- src/node_api.cc | 74 +++++++++---------- src/node_api.h | 36 ++++----- .../2_function_arguments/binding.c | 2 +- test/addons-napi/test_array/test_array.c | 4 +- test/addons-napi/test_buffer/test_buffer.c | 4 +- .../test_constructor/test_constructor.c | 6 +- .../addons-napi/test_function/test_function.c | 2 +- test/addons-napi/test_number/test_number.c | 2 +- test/addons-napi/test_object/test_object.c | 8 +- .../test_properties/test_properties.c | 6 +- test/addons-napi/test_string/test_string.c | 10 +-- test/addons-napi/test_symbol/test_symbol.c | 4 +- .../test_typedarray/test_typedarray.c | 2 +- 13 files changed, 80 insertions(+), 80 deletions(-) diff --git a/src/node_api.cc b/src/node_api.cc index 3b10f32e80b060..30a38f2e64e165 100644 --- a/src/node_api.cc +++ b/src/node_api.cc @@ -234,30 +234,30 @@ static const int kAccessorFieldCount = 3; // info. class CallbackWrapper { public: - CallbackWrapper(napi_value thisArg, int argsLength, void* data) + CallbackWrapper(napi_value thisArg, size_t argsLength, void* data) : _this(thisArg), _argsLength(argsLength), _data(data) {} virtual napi_value Holder() = 0; virtual bool IsConstructCall() = 0; - virtual void Args(napi_value* buffer, int bufferlength) = 0; + virtual void Args(napi_value* buffer, size_t bufferlength) = 0; virtual void SetReturnValue(napi_value v) = 0; napi_value This() { return _this; } - int ArgsLength() { return _argsLength; } + size_t ArgsLength() { return _argsLength; } void* Data() { return _data; } protected: const napi_value _this; - const int _argsLength; + const size_t _argsLength; void* _data; }; template class CallbackWrapperBase : public CallbackWrapper { public: - CallbackWrapperBase(const T& cbinfo, const int argsLength) + CallbackWrapperBase(const T& cbinfo, const size_t argsLength) : CallbackWrapper(JsValueFromV8LocalValue(cbinfo.This()), argsLength, nullptr), @@ -312,9 +312,9 @@ class FunctionCallbackWrapper bool IsConstructCall() override { return _cbinfo.IsConstructCall(); } /*virtual*/ - void Args(napi_value* buffer, int bufferlength) override { - int i = 0; - int min = std::min(bufferlength, _argsLength); + void Args(napi_value* buffer, size_t bufferlength) override { + size_t i = 0; + size_t min = std::min(bufferlength, _argsLength); for (; i < min; i += 1) { buffer[i] = v8impl::JsValueFromV8LocalValue(_cbinfo[i]); @@ -351,11 +351,11 @@ class GetterCallbackWrapper : CallbackWrapperBase(cbinfo, 0) {} /*virtual*/ - void Args(napi_value* buffer, int bufferlength) override { + void Args(napi_value* buffer, size_t bufferlength) override { if (bufferlength > 0) { napi_value undefined = v8impl::JsValueFromV8LocalValue(v8::Undefined(_cbinfo.GetIsolate())); - for (int i = 0; i < bufferlength; i += 1) { + for (size_t i = 0; i < bufferlength; i += 1) { buffer[i] = undefined; } } @@ -383,14 +383,14 @@ class SetterCallbackWrapper : CallbackWrapperBase(cbinfo, 1), _value(value) {} /*virtual*/ - void Args(napi_value* buffer, int bufferlength) override { + void Args(napi_value* buffer, size_t bufferlength) override { if (bufferlength > 0) { buffer[0] = v8impl::JsValueFromV8LocalValue(_value); if (bufferlength > 1) { napi_value undefined = v8impl::JsValueFromV8LocalValue( v8::Undefined(_cbinfo.GetIsolate())); - for (int i = 1; i < bufferlength; i += 1) { + for (size_t i = 1; i < bufferlength; i += 1) { buffer[i] = undefined; } } @@ -659,7 +659,7 @@ napi_status napi_define_class(napi_env e, const char* utf8name, napi_callback constructor, void* data, - int property_count, + size_t property_count, const napi_property_descriptor* properties, napi_value* result) { NAPI_PREAMBLE(e); @@ -683,8 +683,8 @@ napi_status napi_define_class(napi_env e, CHECK_NEW_FROM_UTF8(isolate, namestring, utf8name); tpl->SetClassName(namestring); - int staticPropertyCount = 0; - for (int i = 0; i < property_count; i++) { + size_t staticPropertyCount = 0; + for (size_t i = 0; i < property_count; i++) { const napi_property_descriptor* p = properties + i; if ((p->attributes & napi_static_property) != 0) { @@ -738,7 +738,7 @@ napi_status napi_define_class(napi_env e, std::vector staticDescriptors; staticDescriptors.reserve(staticPropertyCount); - for (int i = 0; i < property_count; i++) { + for (size_t i = 0; i < property_count; i++) { const napi_property_descriptor* p = properties + i; if ((p->attributes & napi_static_property) != 0) { staticDescriptors.push_back(*p); @@ -991,7 +991,7 @@ napi_status napi_get_element(napi_env e, napi_status napi_define_properties(napi_env e, napi_value object, - int property_count, + size_t property_count, const napi_property_descriptor* properties) { NAPI_PREAMBLE(e); @@ -1000,7 +1000,7 @@ napi_status napi_define_properties(napi_env e, v8::Local obj = v8impl::V8LocalValueFromJsValue(object).As(); - for (int i = 0; i < property_count; i++) { + for (size_t i = 0; i < property_count; i++) { const napi_property_descriptor* p = &properties[i]; v8::Local name; @@ -1138,7 +1138,7 @@ napi_status napi_create_array(napi_env e, napi_value* result) { } napi_status napi_create_array_with_length(napi_env e, - int length, + size_t length, napi_value* result) { NAPI_PREAMBLE(e); CHECK_ARG(result); @@ -1151,7 +1151,7 @@ napi_status napi_create_array_with_length(napi_env e, napi_status napi_create_string_utf8(napi_env e, const char* s, - int length, + size_t length, napi_value* result) { NAPI_PREAMBLE(e); CHECK_ARG(result); @@ -1166,7 +1166,7 @@ napi_status napi_create_string_utf8(napi_env e, napi_status napi_create_string_utf16(napi_env e, const char16_t* s, - int length, + size_t length, napi_value* result) { NAPI_PREAMBLE(e); CHECK_ARG(result); @@ -1335,7 +1335,7 @@ napi_status napi_get_true(napi_env e, napi_value* result) { napi_status napi_get_cb_info( napi_env e, // [in] NAPI environment handle napi_callback_info cbinfo, // [in] Opaque callback-info handle - int* argc, // [in-out] Specifies the size of the provided argv array + size_t* argc, // [in-out] Specifies the size of the provided argv array // and receives the actual count of args. napi_value* argv, // [out] Array of values napi_value* thisArg, // [out] Receives the JS 'this' arg for the call @@ -1358,7 +1358,7 @@ napi_status napi_get_cb_info( napi_status napi_get_cb_args_length(napi_env e, napi_callback_info cbinfo, - int* result) { + size_t* result) { // Omit NAPI_PREAMBLE and GET_RETURN_STATUS because no V8 APIs are called. CHECK_ARG(result); @@ -1387,7 +1387,7 @@ napi_status napi_is_construct_call(napi_env e, napi_status napi_get_cb_args(napi_env e, napi_callback_info cbinfo, napi_value* buffer, - int bufferlength) { + size_t bufferlength) { // Omit NAPI_PREAMBLE and GET_RETURN_STATUS because no V8 APIs are called. CHECK_ARG(buffer); @@ -1427,7 +1427,7 @@ napi_status napi_get_cb_data(napi_env e, napi_status napi_call_function(napi_env e, napi_value recv, napi_value func, - int argc, + size_t argc, const napi_value* argv, napi_value* result) { NAPI_PREAMBLE(e); @@ -1439,7 +1439,7 @@ napi_status napi_call_function(napi_env e, v8::Handle v8recv = v8impl::V8LocalValueFromJsValue(recv); - for (int i = 0; i < argc; i++) { + for (size_t i = 0; i < argc; i++) { args[i] = v8impl::V8LocalValueFromJsValue(argv[i]); } @@ -1606,7 +1606,7 @@ napi_status napi_get_value_bool(napi_env e, napi_value value, bool* result) { // Gets the number of CHARACTERS in the string. napi_status napi_get_value_string_length(napi_env e, napi_value value, - int* result) { + size_t* result) { NAPI_PREAMBLE(e); CHECK_ARG(result); @@ -1621,7 +1621,7 @@ napi_status napi_get_value_string_length(napi_env e, // Gets the number of BYTES in the UTF-8 encoded representation of the string. napi_status napi_get_value_string_utf8_length(napi_env e, napi_value value, - int* result) { + size_t* result) { NAPI_PREAMBLE(e); CHECK_ARG(result); @@ -1640,8 +1640,8 @@ napi_status napi_get_value_string_utf8_length(napi_env e, napi_status napi_get_value_string_utf8(napi_env e, napi_value value, char* buf, - int bufsize, - int* result) { + size_t bufsize, + size_t* result) { NAPI_PREAMBLE(e); v8::Local val = v8impl::V8LocalValueFromJsValue(value); @@ -1661,7 +1661,7 @@ napi_status napi_get_value_string_utf8(napi_env e, // the string. napi_status napi_get_value_string_utf16_length(napi_env e, napi_value value, - int* result) { + size_t* result) { NAPI_PREAMBLE(e); CHECK_ARG(result); @@ -1683,8 +1683,8 @@ napi_status napi_get_value_string_utf16_length(napi_env e, napi_status napi_get_value_string_utf16(napi_env e, napi_value value, char16_t* buf, - int bufsize, - int* result) { + size_t bufsize, + size_t* result) { NAPI_PREAMBLE(e); CHECK_ARG(result); @@ -2008,7 +2008,7 @@ napi_status napi_escape_handle(napi_env e, napi_status napi_new_instance(napi_env e, napi_value constructor, - int argc, + size_t argc, const napi_value* argv, napi_value* result) { NAPI_PREAMBLE(e); @@ -2018,7 +2018,7 @@ napi_status napi_new_instance(napi_env e, v8::Local context = isolate->GetCurrentContext(); std::vector> args(argc); - for (int i = 0; i < argc; i++) { + for (size_t i = 0; i < argc; i++) { args[i] = v8impl::V8LocalValueFromJsValue(argv[i]); } @@ -2091,7 +2091,7 @@ napi_status napi_instanceof(napi_env e, napi_status napi_make_callback(napi_env e, napi_value recv, napi_value func, - int argc, + size_t argc, const napi_value* argv, napi_value* result) { NAPI_PREAMBLE(e); @@ -2103,7 +2103,7 @@ napi_status napi_make_callback(napi_env e, v8::Local v8func = v8impl::V8LocalValueFromJsValue(func).As(); std::vector> args(argc); - for (int i = 0; i < argc; i++) { + for (size_t i = 0; i < argc; i++) { args[i] = v8impl::V8LocalValueFromJsValue(argv[i]); } diff --git a/src/node_api.h b/src/node_api.h index f91bddae7ae6aa..c3664049b0daed 100644 --- a/src/node_api.h +++ b/src/node_api.h @@ -113,18 +113,18 @@ NAPI_EXTERN napi_status napi_get_global(napi_env env, napi_value* result); NAPI_EXTERN napi_status napi_create_object(napi_env env, napi_value* result); NAPI_EXTERN napi_status napi_create_array(napi_env env, napi_value* result); NAPI_EXTERN napi_status napi_create_array_with_length(napi_env env, - int length, + size_t length, napi_value* result); NAPI_EXTERN napi_status napi_create_number(napi_env env, double val, napi_value* result); NAPI_EXTERN napi_status napi_create_string_utf8(napi_env env, const char* s, - int length, + size_t length, napi_value* result); NAPI_EXTERN napi_status napi_create_string_utf16(napi_env env, const char16_t* s, - int length, + size_t length, napi_value* result); NAPI_EXTERN napi_status napi_create_boolean(napi_env env, bool b, @@ -170,32 +170,32 @@ NAPI_EXTERN napi_status napi_get_value_bool(napi_env env, // Gets the number of CHARACTERS in the string. NAPI_EXTERN napi_status napi_get_value_string_length(napi_env env, napi_value value, - int* result); + size_t* result); // Gets the number of BYTES in the UTF-8 encoded representation of the string. NAPI_EXTERN napi_status napi_get_value_string_utf8_length(napi_env env, napi_value value, - int* result); + size_t* result); // Copies UTF-8 encoded bytes from a string into a buffer. NAPI_EXTERN napi_status napi_get_value_string_utf8(napi_env env, napi_value value, char* buf, - int bufsize, - int* result); + size_t bufsize, + size_t* result); // Gets the number of 2-byte code units in the UTF-16 encoded // representation of the string. NAPI_EXTERN napi_status napi_get_value_string_utf16_length(napi_env env, napi_value value, - int* result); + size_t* result); // Copies UTF-16 encoded bytes from a string into a buffer. NAPI_EXTERN napi_status napi_get_value_string_utf16(napi_env env, napi_value value, char16_t* buf, - int bufsize, - int* result); + size_t bufsize, + size_t* result); // Methods to coerce values // These APIs may execute user script @@ -258,7 +258,7 @@ NAPI_EXTERN napi_status napi_get_element(napi_env env, NAPI_EXTERN napi_status napi_define_properties(napi_env env, napi_value object, - int property_count, + size_t property_count, const napi_property_descriptor* properties); // Methods to work with Arrays @@ -279,12 +279,12 @@ NAPI_EXTERN napi_status napi_strict_equals(napi_env env, NAPI_EXTERN napi_status napi_call_function(napi_env env, napi_value recv, napi_value func, - int argc, + size_t argc, const napi_value* argv, napi_value* result); NAPI_EXTERN napi_status napi_new_instance(napi_env env, napi_value constructor, - int argc, + size_t argc, const napi_value* argv, napi_value* result); NAPI_EXTERN napi_status napi_instanceof(napi_env env, @@ -296,7 +296,7 @@ NAPI_EXTERN napi_status napi_instanceof(napi_env env, NAPI_EXTERN napi_status napi_make_callback(napi_env env, napi_value recv, napi_value func, - int argc, + size_t argc, const napi_value* argv, napi_value* result); @@ -306,7 +306,7 @@ NAPI_EXTERN napi_status napi_make_callback(napi_env env, NAPI_EXTERN napi_status napi_get_cb_info( napi_env env, // [in] NAPI environment handle napi_callback_info cbinfo, // [in] Opaque callback-info handle - int* argc, // [in-out] Specifies the size of the provided argv array + size_t* argc, // [in-out] Specifies the size of the provided argv array // and receives the actual count of args. napi_value* argv, // [out] Array of values napi_value* thisArg, // [out] Receives the JS 'this' arg for the call @@ -314,11 +314,11 @@ NAPI_EXTERN napi_status napi_get_cb_info( NAPI_EXTERN napi_status napi_get_cb_args_length(napi_env env, napi_callback_info cbinfo, - int* result); + size_t* result); NAPI_EXTERN napi_status napi_get_cb_args(napi_env env, napi_callback_info cbinfo, napi_value* buffer, - int bufferlength); + size_t bufferlength); NAPI_EXTERN napi_status napi_get_cb_this(napi_env env, napi_callback_info cbinfo, napi_value* result); @@ -337,7 +337,7 @@ napi_define_class(napi_env env, const char* utf8name, napi_callback constructor, void* data, - int property_count, + size_t property_count, const napi_property_descriptor* properties, napi_value* result); diff --git a/test/addons-napi/2_function_arguments/binding.c b/test/addons-napi/2_function_arguments/binding.c index 0b0b2b0c04d171..701fe859dcb88c 100644 --- a/test/addons-napi/2_function_arguments/binding.c +++ b/test/addons-napi/2_function_arguments/binding.c @@ -3,7 +3,7 @@ void Add(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; diff --git a/test/addons-napi/test_array/test_array.c b/test/addons-napi/test_array/test_array.c index b7bdf7f11340e9..444a11e3d9886b 100644 --- a/test/addons-napi/test_array/test_array.c +++ b/test/addons-napi/test_array/test_array.c @@ -4,7 +4,7 @@ void Test(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -74,7 +74,7 @@ void Test(napi_env env, napi_callback_info info) { void New(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; diff --git a/test/addons-napi/test_buffer/test_buffer.c b/test/addons-napi/test_buffer/test_buffer.c index cc73a91312543d..44c98ebf36bf54 100644 --- a/test/addons-napi/test_buffer/test_buffer.c +++ b/test/addons-napi/test_buffer/test_buffer.c @@ -78,7 +78,7 @@ void copyBuffer(napi_env env, napi_callback_info info) { } void bufferHasInstance(napi_env env, napi_callback_info info) { - int argc; + size_t argc; NAPI_CALL(env, napi_get_cb_args_length(env, info, &argc)); JS_ASSERT(env, argc == 1, "Wrong number of arguments"); napi_value theBuffer; @@ -97,7 +97,7 @@ void bufferHasInstance(napi_env env, napi_callback_info info) { } void bufferInfo(napi_env env, napi_callback_info info) { - int argc; + size_t argc; NAPI_CALL(env, napi_get_cb_args_length(env, info, &argc)); JS_ASSERT(env, argc == 1, "Wrong number of arguments"); napi_value theBuffer, returnValue; diff --git a/test/addons-napi/test_constructor/test_constructor.c b/test/addons-napi/test_constructor/test_constructor.c index cad34838fa8a20..5a45da30739d6d 100644 --- a/test/addons-napi/test_constructor/test_constructor.c +++ b/test/addons-napi/test_constructor/test_constructor.c @@ -6,7 +6,7 @@ napi_ref constructor_; void GetValue(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -26,7 +26,7 @@ void GetValue(napi_env env, napi_callback_info info) { void SetValue(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -46,7 +46,7 @@ void SetValue(napi_env env, napi_callback_info info) { void Echo(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; diff --git a/test/addons-napi/test_function/test_function.c b/test/addons-napi/test_function/test_function.c index db57f2b9fdf4e8..3619049cd4487e 100644 --- a/test/addons-napi/test_function/test_function.c +++ b/test/addons-napi/test_function/test_function.c @@ -3,7 +3,7 @@ void Test(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; diff --git a/test/addons-napi/test_number/test_number.c b/test/addons-napi/test_number/test_number.c index 6b7cb0f7c9a5e1..1b4dff5631d983 100644 --- a/test/addons-napi/test_number/test_number.c +++ b/test/addons-napi/test_number/test_number.c @@ -3,7 +3,7 @@ void Test(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; diff --git a/test/addons-napi/test_object/test_object.c b/test/addons-napi/test_object/test_object.c index 6a9ca54b28586e..1242cce3230eeb 100644 --- a/test/addons-napi/test_object/test_object.c +++ b/test/addons-napi/test_object/test_object.c @@ -3,7 +3,7 @@ void Get(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -48,7 +48,7 @@ void Get(napi_env env, napi_callback_info info) { void Set(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -96,7 +96,7 @@ void Set(napi_env env, napi_callback_info info) { void Has(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -169,7 +169,7 @@ void New(napi_env env, napi_callback_info info) { void Inflate(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; diff --git a/test/addons-napi/test_properties/test_properties.c b/test/addons-napi/test_properties/test_properties.c index 35db5975f77278..9474e97266649b 100644 --- a/test/addons-napi/test_properties/test_properties.c +++ b/test/addons-napi/test_properties/test_properties.c @@ -5,7 +5,7 @@ static double value_ = 1; void GetValue(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -25,7 +25,7 @@ void GetValue(napi_env env, napi_callback_info info) { void SetValue(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -45,7 +45,7 @@ void SetValue(napi_env env, napi_callback_info info) { void Echo(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; diff --git a/test/addons-napi/test_string/test_string.c b/test/addons-napi/test_string/test_string.c index ba3c55de342494..d8b27ce79c7bef 100644 --- a/test/addons-napi/test_string/test_string.c +++ b/test/addons-napi/test_string/test_string.c @@ -3,7 +3,7 @@ void Copy(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -43,7 +43,7 @@ void Copy(napi_env env, napi_callback_info info) { void Length(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -65,7 +65,7 @@ void Length(napi_env env, napi_callback_info info) { return; } - int length; + size_t length; status = napi_get_value_string_length(env, args[0], &length); if (status != napi_ok) return; @@ -80,7 +80,7 @@ void Length(napi_env env, napi_callback_info info) { void Utf8Length(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -102,7 +102,7 @@ void Utf8Length(napi_env env, napi_callback_info info) { return; } - int length; + size_t length; status = napi_get_value_string_utf8_length(env, args[0], &length); if (status != napi_ok) return; diff --git a/test/addons-napi/test_symbol/test_symbol.c b/test/addons-napi/test_symbol/test_symbol.c index e63d9dcc98f9de..a5bbc672fe58d7 100644 --- a/test/addons-napi/test_symbol/test_symbol.c +++ b/test/addons-napi/test_symbol/test_symbol.c @@ -3,7 +3,7 @@ void Test(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; @@ -43,7 +43,7 @@ void Test(napi_env env, napi_callback_info info) { void New(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return; diff --git a/test/addons-napi/test_typedarray/test_typedarray.c b/test/addons-napi/test_typedarray/test_typedarray.c index 7ccebb61d5de69..faa9093912ad5b 100644 --- a/test/addons-napi/test_typedarray/test_typedarray.c +++ b/test/addons-napi/test_typedarray/test_typedarray.c @@ -4,7 +4,7 @@ void Multiply(napi_env env, napi_callback_info info) { napi_status status; - int argc; + size_t argc; status = napi_get_cb_args_length(env, info, &argc); if (status != napi_ok) return;