Skip to content

Commit

Permalink
Require npm@7 and nodejs 14.* (#10674)
Browse files Browse the repository at this point in the history
* Require npm@7 to support lock files v2

* Use `npm install -g npm@7`

* Require nodejs 14.* for dev/CI

* Use nodejs 14.* in CI envs

* Update lock files in examples/tests
  • Loading branch information
mattpap committed Nov 15, 2020
1 parent ce97a3f commit 3bf3636
Show file tree
Hide file tree
Showing 16 changed files with 966 additions and 3,498 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/bokehjs-ci.yml
Expand Up @@ -20,7 +20,7 @@ jobs:
max-parallel: 3
matrix:
os: [ubuntu-20.04, macos-latest, windows-latest]
node-version: [12.x]
node-version: [14.x]

steps:
- name: Checkout the repository
Expand All @@ -34,7 +34,7 @@ jobs:
- name: Upgrade npm
shell: bash
run: |
npm install -g npm
npm install -g npm@7
- name: Install dependencies
working-directory: ./bokehjs
Expand Down
4 changes: 2 additions & 2 deletions bokehjs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions bokehjs/package.json
Expand Up @@ -17,8 +17,8 @@
"url": "https://github.com/bokeh/bokeh.git"
},
"engines": {
"node": ">=12.12",
"npm": ">=6.14"
"node": ">=14",
"npm": ">=7"
},
"files": [
"build/js/bokeh*.min.js",
Expand Down
2 changes: 1 addition & 1 deletion ci/environment-build.yml
Expand Up @@ -5,7 +5,7 @@ dependencies:
- python=3.6
- conda-build=3.18.10
- conda-verify=3.4.2
- nodejs>=10.13
- nodejs 14.*
- ripgrep=0.10.0
- setuptools
- yaml
2 changes: 1 addition & 1 deletion ci/environment-release-build.yml
Expand Up @@ -19,7 +19,7 @@ dependencies:
- colorama
- conda-build=3.20.5
- conda-verify=3.4.2
- nodejs>=10.13
- nodejs 14.*
- ripgrep=0.10.0
- setuptools
- yaml
Expand Down
2 changes: 1 addition & 1 deletion ci/environment-release-deploy.yml
Expand Up @@ -8,7 +8,7 @@ dependencies:
- anaconda-client
- boto
- colorama
- nodejs>=10.13
- nodejs 14.*
- setuptools
- twine
- yaml
2 changes: 1 addition & 1 deletion ci/environment-test-3.6.yml
Expand Up @@ -33,7 +33,7 @@ dependencies:
- mypy <=0.782
- nbconvert >=5.4
- networkx
- nodejs >=12.12
- nodejs 14.*
- numba
- pandas
- psutil
Expand Down
2 changes: 1 addition & 1 deletion ci/environment-test-3.7.yml
Expand Up @@ -33,7 +33,7 @@ dependencies:
- mypy <=0.782
- nbconvert >=5.4
- networkx
- nodejs >=12.12
- nodejs 14.*
- numba
- pandas
- psutil
Expand Down
2 changes: 1 addition & 1 deletion ci/environment-test-3.8.yml
Expand Up @@ -33,7 +33,7 @@ dependencies:
- mypy <=0.782
- nbconvert >=5.4
- networkx
- nodejs >=12.12
- nodejs 14.*
- numba
- pandas
- psutil
Expand Down
2 changes: 1 addition & 1 deletion ci/install_node_modules.sh
Expand Up @@ -3,7 +3,7 @@
set -x #echo on

pushd bokehjs
npm install -g npm
npm install -g npm@7
npm ci --no-progress
node make examples --no-build
popd
2 changes: 1 addition & 1 deletion docker-tools/alpine/Dockerfile-from-source
Expand Up @@ -35,7 +35,7 @@ RUN conda config --get channels
# install build time dependencies
RUN conda install --yes --quiet `python scripts/deps.py build`
# install NPM dependencies
RUN npm install -g npm
RUN npm install -g npm@7
WORKDIR $BOKEH_SOURCE_DIR/bokehjs
# build BokehJS
RUN npm ci --no-progress
Expand Down

0 comments on commit 3bf3636

Please sign in to comment.