Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issue with line rendering when selecting indices #11661

Closed
zugzwang5 opened this issue Sep 22, 2021 · 4 comments · Fixed by #11664
Closed

[BUG] Issue with line rendering when selecting indices #11661

zugzwang5 opened this issue Sep 22, 2021 · 4 comments · Fixed by #11664

Comments

@zugzwang5
Copy link

zugzwang5 commented Sep 22, 2021

Description of expected behavior and the observed behavior

This is my first time raising an issue on a public repo. So, if I make any mistakes, I apologise in advance.

The selected area in the plot gets disconnected from the entire plot line, the start of unselected line and end of unselected line joins together.

This happens, only when circle glyphs are added to the plot

Before
before
After
after

from bokeh.plotting import figure, output_file, show
from bokeh.models import ColumnDataSource, BoxSelectTool, ResetTool
import numpy as np

output_file("example.html")

sample_data = np.random.rand(20)

source = ColumnDataSource(
    data=dict(x=np.arange(0, len(sample_data)), y=sample_data)
)
color_brewer = ["#31a354", "#addd8e"]

p = figure(width=1000, height=400, tools="box_select, reset", active_drag="box_select")
p.line(x='x', y='y', source=source, line_width=7, line_color=color_brewer[1])
p.circle(x='x', y='y', source=source, size=7, line_color=color_brewer[0], color=color_brewer[0])

show(p)

Screenshots or screencasts of the bug in action

Animation5
example

@bryevdv
Copy link
Member

bryevdv commented Sep 22, 2021

@Lukas-Trisauskas thank you or the very detailed bug report

cc @bokeh/dev This seems to be a slight regression, given the screen capture animations in previous PR #6491 which show the "unselected" line being broken up and not "crossing" the selected points.

@zugzwang5
Copy link
Author

@mattpap Thank you! Is the fix now included in the final package. I already upgraded bokeh to 2.4.0 and the problem still persists.

@mattpap
Copy link
Contributor

mattpap commented Sep 22, 2021

You will have to wait for bokeh 2.4.1, which, I think, we will schedule soon.

@zugzwang5
Copy link
Author

You will have to wait for bokeh 2.4.1, which, I think, we will schedule soon.

@mattpap That's great. Thank you!!

@bryevdv bryevdv modified the milestones: 3.0, 2.4.1 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants