Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use channel instead of explicit version for GMap API? #12112

Closed
bryevdv opened this issue Apr 29, 2022 · 2 comments · Fixed by #12113
Closed

Use channel instead of explicit version for GMap API? #12112

bryevdv opened this issue Apr 29, 2022 · 2 comments · Fixed by #12113

Comments

@bryevdv
Copy link
Member

bryevdv commented Apr 29, 2022

Apparently Google has gotten much more aggressive about completely decommissioning "old" API versions (i.e they stop working entirely). Apparently the default version in 2.4.2 is now de-activated:

https://stackoverflow.com/questions/72056488/plot-points-in-google-map-with-python-with-google-api

Meaning that gmap now no-longer works at all out of the box in any released version of Bokeh.

I guess nowadays there are "release channels" that can be asked for instead:

https://developers.google.com/maps/documentation/javascript/versions#quarterly-updates

So we could use api_version = "quarterly" as a default, instead of a pinned version. The risk there is that some new update from Google is incompatible with our current internal implementation. I am not sure what the best solution is here. It's pretty aggravating that a company with the vast resources of Google won't support a wide range APIs they release.

in any event, the current fixed version in branch-3.0 is already a few versions behind. If we don't switch to channels we should at least update that before release. We need to add documentation support about this aspect as well. cc @tcmetzger

@bryevdv bryevdv added this to the 3.0 milestone Apr 29, 2022
@mattpap
Copy link
Contributor

mattpap commented Apr 29, 2022

I think we use the most common API, that won't change between major releases. We also use very little of that API. So I'm all for this change, especially that I've been trying to keep the version updated, but given their policies, it's not quite doable.

@bryevdv
Copy link
Member Author

bryevdv commented Apr 29, 2022

There is also this:

3.45 After mid-May, this version will be deleted, and can no longer be used. Any attempt to load this version will be ignored, and you will receive your default channel instead.

So I think that starting with 3.45 (which is newer than what Bokeh 2.4.2 specified) that attempts to use a decommissioned version will fall back to a "default" channel (quarterly? it's not clear where "your default channel" is specified). In that case, sticking to a specific version (newer than 3.45) might be OK. But all things considered I think I might still prefer just moving to "quarterly" as the default.

Edit: also meant to cc @bokeh/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants