Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add hover inspection Image glyphs #3886

Closed
ofirsa opened this issue Feb 17, 2016 · 11 comments
Closed

Feature Request: Add hover inspection Image glyphs #3886

ofirsa opened this issue Feb 17, 2016 · 11 comments

Comments

@ofirsa
Copy link

@ofirsa ofirsa commented Feb 17, 2016

Hi, I hope this the right place to ask my question.
is it possible to implement the Hover Tool on image in such a way that when I moving my mouse on the image pixels, I get and information on the pixel below the mouse, like the pixel coordinates and pixel value.
I would be glad to get an example.
Thanks
Saar

@birdsarah
Copy link
Member

@birdsarah birdsarah commented Feb 17, 2016

Hi @ofirsa, our issue tracker is becoming too large to manage easily. We have to reserve it for feature requests and bug reports only, to have any hope of taming it. This kind of general support question should go to the general public mailing list:

https://groups.google.com/a/continuum.io/forum/#!forum/bokeh

@jbednar
Copy link
Contributor

@jbednar jbednar commented Sep 13, 2017

Sorry to revisit this old issue, but as far as I can tell it is still valid. Sarah closed it as a support question, but to me it sounds like either a feature request (can images please support hover information like other glyphs do) or a bug report (images don't support hover information like they should), as requested.

In either case, what's the answer? Is there some fundamental reason why Image shouldn't support hovering to reveal the pixel coordinates and the value of the image at that point? We will need this in our work, and can start working on a PR if that's appropriate.

@jbednar jbednar reopened this Sep 13, 2017
@jbednar
Copy link
Contributor

@jbednar jbednar commented Sep 13, 2017

@canavandl canavandl changed the title Hover Tool on Image Feature Request: Add hover inspection Image glyphs Sep 13, 2017
@bryevdv
Copy link
Member

@bryevdv bryevdv commented Sep 13, 2017

Not sure why this was closed, I thought there was another issue for image hit-testing but I can't find it offhand. Doing this will required setting a "2d" selection, i.e, will want to know which i, j pixel in the image was hit. That's not common, but there should already be kind-of similar example code for MultiLine. There's also the question of what to do when the image is big and a single pixel on the screen spans more than one pixel in the image (e.g. 1000x1000 image in a 500x500 canvas).

Certainly possible in principle, but mostly just needs someone to spend some time thinking about cases like the above, and defining and documenting the exact behaviors. Will need tests too.

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Sep 13, 2017

To be clear: would be a welcome addition, just needs a little upfront thought and design.

@jbednar
Copy link
Contributor

@jbednar jbednar commented Sep 13, 2017

Sounds good. Happy for Jean-Luc to take a stab at it?

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Sep 13, 2017

For sure.

@jkquijas
Copy link

@jkquijas jkquijas commented Jan 4, 2018

Hi! Any update on this feature request/bug report? This functionality can be very useful.

@jbednar
Copy link
Contributor

@jbednar jbednar commented Jan 4, 2018

It's still on @jlstevens's to-do list, and is expected to be addressed soon.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 4, 2018

Yes, I am eager to tackle this although I am currently waiting on the refactor in #7261 to be completed first.

@jkquijas
Copy link

@jkquijas jkquijas commented Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants