Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Correctly handle data values <= 0 on a log scale #5549
This is a continuation from issue #5389, partially adressed by PR #5477. There persists an issue where negative data is not handled correctly. All data <= 0 should be discarded before generating the plot.
As is, if
Taking a quick look at this, the problem is definitely because the computed start for the range is NaN. I remember there was code (
The best thing to do would be to set the minimum data value to the the minimum value that is still > 0. But the min data value is saved into the
I want to try out a few things to see what would be the best solution. @bryevdv @StevenCHowell do you think it is worth it to first add back the hotfix? I could make that small PR tonight and then figure out a better way to fix it.
Also, the workaround now would be to supply a range start and end.
@clairetang6, for the hotfix, setting it to 1 will obviously create other problems (typically my data ranges from 0 to 0.3 ish). As you say, something more like the following would be more appropriate:
I don't think there is a rush to patch this, just to have to return to it later. Did you see issue #5550? Perhaps consider this as well while trying things as it is closely related.