New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMapOptions are not dynamically applied #5592

Closed
pzwang opened this Issue Dec 20, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@pzwang
Contributor

pzwang commented Dec 20, 2016

Any changes to GMapOptions (such as the map style) are only picked up at creation/initialization time, and subsequent changes are not picked up by BokehJS. In https://github.com/bokeh/bokeh/blob/master/bokehjs/src/coffee/models/plots/gmap_plot_canvas.coffee, we will need to add a handler that listens for changes to the GMapOptions and applies them.

The styles attribute of map_options is particularly important, because it's quite conceivable that users will want to dynamically change the visual appearance of the map (or turn on/off certain map features via styling).

@bryevdv

This comment has been minimized.

Show comment
Hide comment
@bryevdv

bryevdv Jan 10, 2017

Member

@pzwang Do you have a test code handy?

Member

bryevdv commented Jan 10, 2017

@pzwang Do you have a test code handy?

@bryevdv bryevdv self-assigned this Jan 19, 2017

@bryevdv bryevdv referenced this issue Jan 28, 2017

Merged

Fix several GMap issues #5693

1 of 1 task complete

@bryevdv bryevdv closed this Jan 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment