Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect freezes IE 11 on change #6333

Closed
decatur opened this Issue May 29, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@decatur
Copy link

decatur commented May 29, 2017

When changing the selection on a MultiSelect widget, IE11 dies.

from bokeh.plotting import curdoc
from bokeh.models.widgets import MultiSelect

def change_callback(attr, old, new):
    print(new)
    
select = MultiSelect(title='Select source', value=['a'], options=['a','b'])
select.on_change('value', change_callback)
curdoc().add_root(select)

Bug confirmed with Bokeh 0.12.4 and IE11.0.9600. change_callback handler is called once (['b'] is printed), then IE hangs. No problem with Select-Widget (single).
See also https://stackoverflow.com/questions/41839541/bokeh-multiselect. A related issue could be #5832.

@bryevdv

This comment has been minimized.

Copy link
Member

bryevdv commented May 29, 2017

@decatur can you test 0.12.5, and ideally with a 0.12.6 dev build? If there was an issue in the past its possible it has been fixed since and it is important to determine that as a first step. Dev builds are easily installable:

http://bokeh.pydata.org/en/latest/docs/installation.html#developer-builds

Can you verify this problem is limited to IE11 and not other browsers?

@bryevdv

This comment has been minimized.

Copy link
Member

bryevdv commented May 29, 2017

For reference I cannot reproduce any problem with either of those (or with 0.12.4) on OSX/Safari.

@blacknapkins

This comment has been minimized.

Copy link

blacknapkins commented May 29, 2017

I have tried the given example on Win 7 IE 11 with the same issue; a crash occurs after the ['b'] is printed. I used Bokeh 0.12.6dev6 and Python 3.5.3.
Chrome and Firefox do not display this erroneous behaviour.
The IE 11 JS console does not display any information prior to the crash occurring.

With IE 11 connected I get the following output every so often, which may or may not be connected.

Traceback (most recent call last):
File "C:\ProgramData\Anaconda3\envs\bok_0_12_6dev6\lib\site-packages\bokeh\ser
ver\views\ws.py", line 167, in on_pong
self.latest_pong = int(codecs.decode(data, 'utf-8'))
ValueError: invalid literal for int() with base 10: ''
2017-05-29 18:43:48,447 received invalid integer in pong b''

@bryevdv

This comment has been minimized.

Copy link
Member

bryevdv commented May 29, 2017

@blacknapkins thanks for the update. It's unfortunately probably too late to do anything about this for 0.12.6 but I have slated it for a look for the following release.

FYI AFAIK the message about the pong is annoying, but harmless. We've not been able to track down a solid repeatable test case for it but it never seems to interfere with expected behavior either.

@blacknapkins

This comment has been minimized.

Copy link

blacknapkins commented May 30, 2017

@bryevdv thanks for the info wrt the pong, I had a vague memory of seeing that somewhere but couldn't find it when I had a quick look.

@decatur

This comment has been minimized.

Copy link
Author

decatur commented May 30, 2017

Yes, we have the exact same symptoms as @blacknapkins observes. Because he did already test against the dev build, I will refrain (sitting behind a not so cooperative corporate firewall).
Btw, corporate policies often dictate the deployed browser, which also often is IE exclusively.

@bryevdv bryevdv modified the milestones: 0.12.7, 0.12.8 Aug 23, 2017

@bryevdv bryevdv modified the milestones: 0.13.x, short-term Sep 11, 2018

@bryevdv

This comment has been minimized.

Copy link
Member

bryevdv commented Mar 8, 2019

The code above now works on Win 10 / IE 11 with 1.1.0dev9, so I will close this. Can re-open if a problem persists and can be made reproducible

@bryevdv bryevdv closed this Mar 8, 2019

@bryevdv bryevdv modified the milestones: short-term, 1.1 Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.