Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker not updating enabled/disabled #6728

Closed
bryevdv opened this issue Aug 5, 2017 · 4 comments · Fixed by #9509
Closed

DatePicker not updating enabled/disabled #6728

bryevdv opened this issue Aug 5, 2017 · 4 comments · Fixed by #9509

Comments

@bryevdv
Copy link
Member

bryevdv commented Aug 5, 2017

this seems to just be a case of missing plumbing (I don't see any change handlers hooked up)

ref: https://groups.google.com/a/continuum.io/forum/#!topic/bokeh/frzcAhV7zYw

test code:

from bokeh.layouts import widgetbox
from bokeh.models import widgets
from bokeh.plotting import curdoc

def change_time():
    print('previous values: ', time.value, time.min_date, time.max_date)
    time.value = '2015-11-10'
    time.min_date = '2015-10-01'
    time.max_date = '2015-12-30'
    print('changed values: ', time.value, time.min_date, time.max_date)

time = widgets.inputs.DatePicker(title="Intervention", value='2015-11-02', min_date='2015-11-01', max_date='2015-12-01')
button = widgets.Button(label="Change time", button_type="success")
button.on_click(change_time)
layout = widgetbox([time,button])

curdoc().add_root(layout)
@mb-magnitude
Copy link

This bug also affects properties like disabled; so you can't enable/disable a DatePicker programmatically.

Is there a revised milestone for this bug, given we are > 0.12.8?

@bryevdv bryevdv modified the milestones: 0.13.x, short-term Sep 11, 2018
@bryevdv bryevdv modified the milestones: short-term, 1.1.1 Mar 8, 2019
@mattpap mattpap modified the milestones: 1.1.1, short-term Apr 29, 2019
@bryevdv
Copy link
Member Author

bryevdv commented Jul 13, 2019

there is an inflight PR for #8934 that will fix the original reported issue (dupe) but it will not affect anything with enabled/disabled so I will re-purpose this issue for that.

@mb-magnitude there is no update, if there were it would be here. There are unfortunately many more issues than contributors at the present time so some things will simply take a long time to get to.

@bryevdv bryevdv changed the title DatePicker not updating in apps DatePicker not updating enabled/disabled Jul 13, 2019
@bryevdv
Copy link
Member Author

bryevdv commented Jul 13, 2019

Noting for the future that DatePicker is one of the few remaining widgets that needs selenium tests added.

@bryevdv bryevdv mentioned this issue Jan 17, 2020
5 tasks
@bryevdv bryevdv modified the milestones: short-term, 2.0 Jan 17, 2020
@bryevdv
Copy link
Member Author

bryevdv commented Jan 17, 2020

#9509 fixes this and many other datepicker issues (as well as adds selenium tests) for 2.0 but note that the implementaton was switched to Flatpickr, and also now date values can only be expressed as ISO date strings, or datetime.date and nothing else (in particular no more datetime values which caused endless trouble with time zones)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants