Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutocompleteInput does not complete word when option is clicked #6822

Closed
tkchris93 opened this Issue Aug 27, 2017 · 15 comments

Comments

Projects
None yet
9 participants
@tkchris93
Copy link

tkchris93 commented Aug 27, 2017

I am using MacOS, Bokeh 0.12.7rc3, python 2.7.13, and Google Chrome to view a static html file generated by Bokeh. Clicking on a word in the autocomplete dropdown only sometimes (~25%) completes the word in the input box. I have not been able to see any pattern as to when it works and when it doesn't. There is no additional information to share from the javascript console.

from bokeh.plotting import show, output_file
from bokeh.models.widgets import AutocompleteInput

output_file('autocomplete_input.html')

input_widget = AutocompleteInput(completions=['pok', 'wer', 'foo', 'bar', 'baz'], title='test')
show(input_widget)

@mattpap mattpap self-assigned this Aug 27, 2017

@mattpap mattpap added this to the 0.12.7 milestone Aug 27, 2017

@mattpap

This comment has been minimized.

Copy link
Contributor

mattpap commented Aug 27, 2017

This is a bizarre bug.

@bryevdv bryevdv modified the milestones: 0.12.7, 0.12.8 Aug 29, 2017

@guojunchi11

This comment has been minimized.

Copy link

guojunchi11 commented Nov 21, 2017

This happens to me, too.
Also, I can not use the down arrow on the keyboard to select, have to use the mouse

@RafaelPais

This comment has been minimized.

Copy link

RafaelPais commented Jan 17, 2018

Same behavior in bokeh 0.12.13, any update about this?

@bryevdv

This comment has been minimized.

Copy link
Member

bryevdv commented Jan 18, 2018

@RafaelPais sorry, unfortunately not. Generally speaking, there is currently a large excess of issues relative to the number of core contributors, meaning some things will simply not be able to get done for a long time, unless new contributors get involved. If you have the interest and ability, I'm happy to point you in the right direction to get started.

@RafaelPais

This comment has been minimized.

Copy link

RafaelPais commented Jan 19, 2018

@bryevdv Many thanks for the prompt reply. Yes, I'm interested in contributing. I'll take note of the documentation available in the Getting Set Up section on DEVELOPER GUIDE. However, I will be very pleased if you can direct me to code related to autocomplete. I have a special interest in solving this problem.

@bryevdv

This comment has been minimized.

Copy link
Member

bryevdv commented Jan 19, 2018

@RafaelPais Absolutely, the python model is defined here:

https://github.com/bokeh/bokeh/blob/master/bokeh/models/widgets/inputs.py#L65

I doubt there is much to see or do there, but just for reference. All the work is done in the JS implementation, which is here:

https://github.com/bokeh/bokeh/blob/master/bokehjs/src/coffee/models/widgets/autocomplete_input.ts

@DanielaBreitman

This comment has been minimized.

Copy link

DanielaBreitman commented Jul 25, 2018

@bryevdv This issue still seems to occur in bokeh==0.13.0. Is there any workaround?

@bryevdv bryevdv modified the milestones: 0.13.x, short-term Sep 11, 2018

@magee256

This comment has been minimized.

Copy link

magee256 commented Nov 26, 2018

I'm still seeing this in bokeh==1.0.1, this pull request references a layout rework that should fix the issue. Is that rework still ongoing?

@linusmarco

This comment has been minimized.

Copy link

linusmarco commented Dec 21, 2018

I'm also still experiencing this issue in 1.0.0.

@mattpap, is the layout rework still ongoing? I didn't see a link to an issue or PR where you referenced the work here, but it looks like the AutocompleteInput TS code hasn't been updated recently so my guess is that it's still in progress.

Are you open to a new PR on this?

@mattpap mattpap modified the milestones: short-term, 1.1 Dec 21, 2018

@mattpap

This comment has been minimized.

Copy link
Contributor

mattpap commented Dec 21, 2018

This is fixed in PR #8085.

@chaoukiiiii

This comment has been minimized.

Copy link

chaoukiiiii commented Jan 30, 2019

Hello, I'm facing the same issue in 1.0.4, how to solve it? any update?

@linusmarco

This comment has been minimized.

Copy link

linusmarco commented Jan 30, 2019

@chaoukiiiii, PR #8085 referenced above is still pending. It's a massive PR and looks like there's still a bit of work to be done on it.

@mattpap

This comment has been minimized.

Copy link
Contributor

mattpap commented Jan 30, 2019

Hopefully it will be merged tomorrow. We will see how that goes.

@bryevdv

This comment has been minimized.

Copy link
Member

bryevdv commented Jan 31, 2019

@mattpap FYI I would say the original code above works, in that the drop down always seems to show up with the correct suggestions now. However, it only seems possible to choose a selection by clicking on it, i.e. can't arrow down and press enter. Fine making that a new issue but I think it's a reasonable expectation for this widget.

@bryevdv

This comment has been minimized.

Copy link
Member

bryevdv commented Feb 1, 2019

Would suggest follow on issues re: specific UX interaction improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.