Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable autoEdit expose #6864

Closed
rmchurch opened this issue Sep 1, 2017 · 1 comment · Fixed by #10353
Closed

DataTable autoEdit expose #6864

rmchurch opened this issue Sep 1, 2017 · 1 comment · Fixed by #10353

Comments

@rmchurch
Copy link

rmchurch commented Sep 1, 2017

Would be nice to expose autoEdit option of SlickGrid for DataTable (changes so a single-click instead of double begins editing cell). I wrote custom extension below, may think of giving as optional parameter though.

import * as p from "core/properties"
import {DataTable, DataTableView} from "models/widgets/tables/data_table"

export class customDataTableView extends DataTableView

	render: () ->
		super()

		@grid.setOptions({autoEdit:@model.autoEdit})

export class customDataTable extends DataTable
	default_view: customDataTableView
	type: 'customDataTable'

	@define { autoEdit: [p.Bool,false] }
@bryevdv
Copy link
Member

bryevdv commented Sep 5, 2017

@rmchurch If you submit a PR to add this to the built-in table with autoEdit changed to auto_edit to match the property naming convention, I will be happy to merge it. You will probably be able to get to it much sooner than anyone else (some folks are out the entire next month and others are switching projects)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants