Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rect shape gets out of figure when panned or zoomed with WebGL #6867

Closed
vtphan opened this issue Sep 2, 2017 · 6 comments
Closed

rect shape gets out of figure when panned or zoomed with WebGL #6867

vtphan opened this issue Sep 2, 2017 · 6 comments

Comments

@vtphan
Copy link

@vtphan vtphan commented Sep 2, 2017

Anaconda, bokeh 0.12.7
rect shape gets out of figure when panned or zoomed. See figure:

screen shot 2017-09-01 at 8 30 12 pm

fig = figure(
	plot_width = DIM[2,0][0],
	plot_height= DIM[2,0][1],
	x_range = main_fig.x_range,
	y_range = (-3.5,2),
	tools=['reset,tap,xwheel_zoom',a_hover],
	toolbar_location=None,
	active_scroll="xwheel_zoom",
	output_backend="webgl",
	logo=None,
)
fig.xgrid.grid_line_color = None
fig.xaxis.axis_label_text_font_style = "normal"
fig.xaxis.axis_label_text_font_size = "14pt"
fig.xaxis[0].formatter = NumeralTickFormatter(format="0")
fig.ygrid.grid_line_color = None
fig.yaxis.visible = False

fig.rect(
	x = 'x',
	y = 'y',
	width = 'width',
	height = 'height',
	color = 'color',
	fill_alpha = 'fill_alpha',
	line_alpha = 'line_alpha',
	line_width = 'line_width',
	nonselection_color = 'color',
	width_units = 'data',
	height_units = 'data',
	name = 'gene_product',
	source = source
)
@bryevdv
Copy link
Member

@bryevdv bryevdv commented Sep 2, 2017

This is a webgl specific problem

@vtphan
Copy link
Author

@vtphan vtphan commented Sep 2, 2017

Wow. Not setting the backend_parameter to webgl fixes it. Thanks.

PS: it wasn't a problem in version 0.12.5. It only became a problem in 0.12.6 and 0.12.7

@mattpap
Copy link
Contributor

@mattpap mattpap commented Sep 2, 2017

Unfortunately we have limited capabilities to test the webgl implementation, which means it slowly deviates from the default rendering algorithm.

@bryevdv bryevdv changed the title rect shape gets out of figure when panned or zoomed rect shape gets out of figure when panned or zoomed with WebGL Sep 2, 2017
@bryevdv bryevdv added this to the short-term milestone Sep 2, 2017
@bryevdv
Copy link
Member

@bryevdv bryevdv commented Sep 2, 2017

My intent is to redo GL support from the ground up, probably based on ReGL, but that is a large undertaking, and certainly will have to happen post-1.0

@David-Herman
Copy link
Contributor

@David-Herman David-Herman commented Nov 21, 2017

I wanted to leave a note that I observe the same behavior when using the graph network plotting capability in Bokeh. Circles properly respect the boundary and edges cross over the axes.

image

@bryevdv
Copy link
Member

@bryevdv bryevdv commented Nov 21, 2017

I hope some day to be able to re-do the entire webGL backend using something like ReGL but that's a substantial project, outside my current experience, an there are many other priorities ahead of it. So it probably won't be any time soon unless someone else decides to take it up first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants