-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
webgl incorrect clipping, 0.12.11 onwards #7211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Which version of Firefox and what platform? |
Problem appears in Firefox 56.0 (64-bit), both standard and developer edition under Ubuntu 17.04 and 16.04. |
Are there any error in JS console? E.g.:
I have exactly the same setup in my dev VM and on my host system, and in VM it works and fails on host. Anyway, what you observe here is that webgl wasn't allowed to be initialized (I suspect it's a configuration issue), so bokeh fell back to software rendering, but didn't properly set up clipping region (as this is done by webgl renderer if requested). |
https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers may help enabling webgl. |
Hi,
Working in a VM. |
On my Windows laptop, I have the same problem. The rectangle where glyphs are displayed does not match with the figure axis. Edit: I realized this has already been adressed and commented on in another issue (#6867) |
Similar issues on MacOS. In Firefox, with webgl enabled, I only see overflow on the top or bottom axes on some plots (see below) Though it seems like the 'view' is just shifted in one direction. Both from https://bokeh.pydata.org/en/latest/docs/user_guide/webgl.html In Chrome, with webgl disabled, I see overflow on all sides. Firefox console warning:
Chrome console warning:
Mac OS X 10.13.1 |
I've updated the title, and marked as bug. Go to User Guide -> Speeding up with WebGL For 0.12.10 and then 0.12.11 onwards and I see this bug on Chrome and Firefox. Am marking this one as other reportees are being directed here. |
Figured it wasn't worth screenshotting all the possible combinations in between. |
WebGL is currently a mess. Not surprising since it is not really under automated test at the moment, and there is no one spending time maintaining it. It might be possible to get SauceLabs test running again to help with WebGL. They broke when we refactored the build to switch to TravisCI stages. I was not able to get them working again, despite trying. More preferable to me personally tho, would be getting locally runnable image diff tests based off Chrome Headless working, since CH supports webgl. Longer term I'd like to consider not supporting two backends, maybe basing BokehJS on ReGL for non-text rendering, but that's currently pie in the sky planning |
I was quite excited for this fix, so I have cloned and built Bokeh 0.12.15dev6+1.ga2949b2. import numpy as np
import bokeh
from bokeh.plotting import figure
from bokeh.io import curdoc
from bokeh.layouts import row
#backend = 'canvas'
backend = 'webgl'
N = 10000
np.random.seed(0) # Fix random
x = np.random.normal(0, np.pi, N)
y = np.sin(x) + np.random.normal(0, 0.2, N)
p1 = figure(title='Works fine', output_backend=backend)
p1.circle(x, y, fill_alpha=0.1)
p2 = figure(title='Compare for blurriness', output_backend=backend)
p2.circle(x, y, fill_alpha=0.1)
x = np.linspace(0, 10*np.pi, N)
y = np.cos(x) + np.sin(2*x+1.25) + np.random.normal(0, 0.001, (N, ))
p3 = figure(title='Drawing outside plot area happens', output_backend=backend)
p3.line(x, y, color="#22aa22", line_width=3)
curdoc().add_root(row(p1, p2, p3))
curdoc().title = backend+' '+bokeh.__version__ ... But maybe there is more to this and it deserves a new issue:
I hope those explanations make somewhat sense! |
webgl disables LOD, so if you see LOD-like behavior, webgl is off. This may be a recent regression in webgl initialization code. |
In any case that's a separate problem, so please file a new GH issue with this information |
It's completely broken (#7681). |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When webgl is enabled and firefox is used after zooming or panning glyphs can go outside the axes.
Moving them back can also leave some "garbages" outside axes.
Can be reproduced in:

https://bokeh.pydata.org/en/latest/docs/user_guide/webgl.html
This issue do not appear at chrome, or edge
The text was updated successfully, but these errors were encountered: