Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Unable to edit dataTable cell #7891
I'm using Bokeh 0.12.15 (latest) and after I modify a DataTable cell, I can't save the update. The only thing I can do is focus to the cell and press escape, otherwise the whole DataTable looses focus and is not selectable nor editable.
Is this a regression?
It's the same behavior whether using a notebook or not.
Also, it seems the IntEditor has no effect whatsoever.
hello @bryevdv, the code provided in this ticket can be used as is.
The result is the same with a bokeh server.
@ongietorri Respectfully that is not true, the original code in the ticket did not have imports (images of code cannot be copied and pasted and are generally worthless). There are many tens (hundreds?) of thousands of users, and only two core devs. Adding a few imports or missing code may not seem like alot, but when you multiply it across the entire user base it becomes a large burden for just a few people. In the interests of fairness and sustainability, we must insist on complete (text) code samples.
Now, with complete code I can confirm a bug. I am currently traveling for a family medical situation, but will look at it when I am able.
@mattpap any ideas what's going on her? I thought we fixed this. It's not even activating the editor at all now. We absolutely have to find some way to maintain this under test.
tag: component: bokehjs
May 15, 2018
The regression happened in PR #7818. Reverting it helps, though there are still some unrecoverable stylistic issues after editing. With that PR applied, strange things happen. Double click event, which is responsible for enabling edit mode, is not routed correctly, if at all, thus there is no way to have an editor initialized. It seems that the way slickgrid sets up click and double click events with jquery, shouldn't work reliably in general, I replaced that code with hammerjs. With event routing fixed, editable mode still doesn't work, because as soon as editor is created, slickgrid returns to display mode. This is because it thinks that the active cell changed, but it didn't. At this point I don't know what's the underlying cause.
referenced this issue
May 25, 2018
@zanapepaj I don't really understand what you are saying specifically. Are you saying things work on other plaforms, but don't work on windows? If that's the case, what versions (of bokeh, browser, and windows). Also if that's the case, it would be more helpful for you to make a new issue (with all that information, and a test script to reproduce the problem) so that we can tag it appropriately as windows-specific.
I am working on Windows 10, Chromium 61.0.3163.100 and bokeh 1.0.0.dev2 and this example is working well for me.