Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentLifeCycleHandler should catch exception and clean up callbacks #8367

Closed
philippjfr opened this issue Oct 26, 2018 · 0 comments
Closed

DocumentLifeCycleHandler should catch exception and clean up callbacks #8367

philippjfr opened this issue Oct 26, 2018 · 0 comments

Comments

@philippjfr
Copy link
Contributor

@philippjfr philippjfr commented Oct 26, 2018

The DocumentLifeCycleHandler allows adding on_session_destroyed callbacks to a Document, which works pretty well. However if a single callback fails for whatever reason other callbacks won't be called. Additionally the references to the callbacks themselves may be prevent references from being collected, therefore the handler should delete the callbacks once it is done with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.