Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot y-axis label blurry on windows 10 #8478

Closed
anthonydouc opened this issue Dec 2, 2018 · 17 comments
Closed

Plot y-axis label blurry on windows 10 #8478

anthonydouc opened this issue Dec 2, 2018 · 17 comments

Comments

@anthonydouc
Copy link
Contributor

anthonydouc commented Dec 2, 2018

Not sure if there is a current open issue capturing this, but on windows 10 the the y-axis labels are particularly distorted. It looks like it is somewhat zoomed out, so when zooming in at 200-250% it looks alot closer to how it does on osx.

The same thing occurs across google chome and firefox. Edge is actually a bit better.

Mac osx (google chrome)
iris_mac

Windows 10 chrome (100% zoom)
iris_win10_100

Windows 10 chrome (200% zoom)
iris_win10_200

@mattpap
Copy link
Contributor

mattpap commented Dec 3, 2018

Can you try out different fonts (we use helvetica by default) and see if the problem persists (set axis_label_text_font property)? We don't have reliable access to windows (especially 10) machines, so it may take a while for us to get to this issue.

@anthonydouc
Copy link
Contributor Author

Google chrome, with times new roman (zoom at 100%):
bokeh_plot 29

Google chrome, with times new roman (zoom in to 200%):
bokeh_plot 30

Edge, with times new roman (zoom at 100%):
bokeh_plot

@xavArtley
Copy link
Contributor

Windows 10 chrome:
I don't notice a real blur problem at any zoom level :
image

image

image

@anthonydouc
Copy link
Contributor Author

Windows 10 chrome:
I don't notice a real blur problem at any zoom level :
image

image

image

Which version of bokeh are you using

@xavArtley
Copy link
Contributor

xavArtley commented Mar 21, 2019 via email

@anthonydouc
Copy link
Contributor Author

It still looks blury to me. Even in the images you sent through at 100% zoom the text looks distorted - when you zoom further in it looks improved. I suspect it would be associated with a canvas drawing issue

@mattpap
Copy link
Contributor

mattpap commented Mar 21, 2019

I suspect it would be associated with a canvas drawing issue

Most likely that's the case and there may be nothing we can do about it in general. However, it would be good to know what advice to give users in future. @anthonydouc, can you try using non-italic or unstyled font, or a different font altogether for the vertical axis? Maybe there is a combination that works more reasonably.

@mattpap
Copy link
Contributor

mattpap commented Mar 21, 2019

Actually, I already asked earlier for a different font, so lets focus on styling this time.

@jxramos
Copy link

jxramos commented May 5, 2019

@anthonydouc I'm interested in the context of the blurriness. Is it something you're finding directly in the browser? Are these images you present generated by the save button floppy disk icon on the bokeh toolbar? Are these screenshots?
When I download the images as served by gitHub here I actually find different resolutions, the Mac version being twice as large...

Mac osx (google chrome):        Width 1224, Height 1188, Bit depth 32 
Windows 10 chrome (100% zoom):  Width 618 , Height 599 , Bit depth 32 

@bryevdv
Copy link
Member

bryevdv commented May 5, 2019

the Mac version being twice as large...

That's a function of the retina display and the corresponding different device pixel ratio on the mac

@anthonydouc
Copy link
Contributor Author

@anthonydouc I'm interested in the context of the blurriness. Is it something you're finding directly in the browser? Are these images you present generated by the save button floppy disk icon on the bokeh toolbar? Are these screenshots?
When I download the images as served by gitHub here I actually find different resolutions, the Mac version being twice as large...

Mac osx (google chrome):        Width 1224, Height 1188, Bit depth 32 
Windows 10 chrome (100% zoom):  Width 618 , Height 599 , Bit depth 32 

Sorry have not had time to look further into this.
Although the images attached are screenshots, they are observed directly in the browser.

But perhaps those issues are related? When you zoom in at 200% it seems to not be blurry.

@bryevdv
Copy link
Member

bryevdv commented Feb 20, 2020

Have not looked at this article in detail but it does claim that the approach we have taken is "outdated" and presents an alternative method for dealing with a blurry canvas. Possibly worth investigating when time permits

https://medium.com/wdstack/fixing-html5-2d-canvas-blur-8ebe27db07da

@mattpap
Copy link
Contributor

mattpap commented Feb 20, 2020

This article doesn't bring anything new to the picture. We use the same HiDPI approach as everyone else. If this was a problem with pixel density, we would see other artifacts as well. I observed this problem before in phantomjs, which leads me to conclusion that this may be just an issue with an outdated browser. Unfortunately we didn't ask for the version of chrome being used. Then there's a possibility that there was a regression in chrome at some point affecting font rendering on this particular platform.

@anthonydouc
Copy link
Contributor Author

This article doesn't bring anything new to the picture. We use the same HiDPI approach as everyone else. If this was a problem with pixel density, we would see other artifacts as well. I observed this problem before in phantomjs, which leads me to conclusion that this may be just an issue with an outdated browser. Unfortunately we didn't ask for the version of chrome being used. Then there's a possibility that there was a regression in chrome at some point affecting font rendering on this particular platform.

Happy to check to see if the same problems occur and provide a chrome version if that is helpful.

@mattpap
Copy link
Contributor

mattpap commented Feb 20, 2020

Actually, we still use backingStorePixelRatio. I must have removed this in PR that got stalled. Though I doubt this affects anything. I will submit a PR and we will see if this changes anything.

@bryevdv
Copy link
Member

bryevdv commented Feb 21, 2020

I will have an rc1 out this weekend with the change. I'd say it would be good to test with it @anthonydouc but fair warning we are probably just going to have to close this issue regardless as there is just not anything else I think we could do or change.

@bryevdv
Copy link
Member

bryevdv commented Mar 4, 2022

Absent any feedback/further information, I am closing this as stale

@bryevdv bryevdv closed this as completed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants