New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyyaml version is vulnerable to CVE-2017-18342 #8541

Closed
alexomics opened this Issue Jan 7, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@alexomics

alexomics commented Jan 7, 2019

The pyyaml version specified here is vulnerable to to CVE-2017-18342.

screen shot 2019-01-07 at 10 26 29

Can this be upgraded without issue?

@bryevdv

This comment has been minimized.

Member

bryevdv commented Jan 7, 2019

It's unclear. The latest version of pyyaml on both PyPI and conda default repositories is 3.13. Evidently the project was taken over by an entirely new team, though I can't find any release of it under the same name.

@bryevdv

This comment has been minimized.

Member

bryevdv commented Jan 7, 2019

Looks like 4.2 is not available yet: yaml/pyyaml#193 We are certainly happy to move on this as soon as a release is available

@bryevdv

This comment has been minimized.

Member

bryevdv commented Jan 7, 2019

FWIW The CVE only seems to pertain to yaml.load. Here are all the instances of yaml.load in the codebase:

./_testing/util/examples.py:
  266 :         examples = yaml.load(f.read())
./themes/theme.py:
  131 :                 json = yaml.load(f)
./util/sampledata.py:
  109 :         config = yaml.load(open(join(bokeh_dir, 'config')))

It would be reasonable to see if yaml.safe_load would work for all of those, in which case that would be a more proactive solution.

@bryevdv bryevdv referenced this issue Jan 7, 2019

Merged

use only yaml.safe_load #8542

1 of 1 task complete
@bryevdv

This comment has been minimized.

Member

bryevdv commented Jan 7, 2019

Testing seems to indicate that yaml.safe_load works fine for Bokeh's needs. I have pushed a PR that switches to only use safe_load. I will make an accelerated 1.0.4 release when this is merged.

@bryevdv bryevdv added the type: task label Jan 7, 2019

@bryevdv bryevdv added this to the 1.0.4 milestone Jan 7, 2019

@bryevdv bryevdv closed this in #8542 Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment