Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Stacked Areas and Lines #8848

Closed
bryevdv opened this issue Apr 18, 2019 · 9 comments

Comments

@bryevdv
Copy link
Member

commented Apr 18, 2019

Strangely, I can't find a suitable issue for this. Anyway, I will submit a PR later this week to add support for this:

Screen Shot 2019-04-17 at 10 21 36 PM

Implementation is basically done, needs docs and tests. Would not mind some feedback on a couple of questions:

  • The harea and varea only have fill props currently. The rationale is that AFAICT these kinds of charts never outline the sides/bottom. Does that seem reasonable?

  • x1 and x2? or x0 and x1?

cc @bokeh/core @bokeh/dev @pzwang for any comments before submitting

@bryevdv

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

For good measure here is how it will look horizontal or negative:

Screen Shot 2019-04-17 at 10 29 33 PM

Screen Shot 2019-04-17 at 10 30 04 PM

@birdsarah

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

The rationale is that AFAICT these kinds of charts never outline the sides/bottom. Does that seem reasonable?

I think that's reasonable. There are certainly workarounds if we decided not to. Excited to see this.

@bryevdv

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2019

@birdsarah do you think it would be OK to ship a first cut of this w/o working hover support? Patch does not currently support hit testing, and I am not sure what it would take to get things working well

@wabu

This comment has been minimized.

Copy link

commented Apr 25, 2019

Does hover work on the borders at least? Had the problem in holoviews and created an invisible lines overlay to get hover on these ...

@bryevdv

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

Stacked area has no border of its own, as discussed above. But hover currently would work on a corresponding stacked line added alongside.

@birdsarah

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

@birdsarah do you think it would be OK to ship a first cut of this w/o working hover support? Patch does not currently support hit testing, and I am not sure what it would take to get things working well

I did not know that patch doesn't support hit testing....that has surprised me. I got it working in this PR https://github.com/bokeh/bokeh/pull/3399/files if there's anything you can crib from that.

I'm more taken aback by the fact that we don't have hit testing on patches, than I am concerned about having it in this case.

@bryevdv

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2019

Patches has hit-testing, Patch does not, because it's one of the weirdo glyphs that isn't actually vectorized, so will need some special casing.

@birdsarah

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Cool. Thanks! I think it's fine to move ahead....and maybe open an issue for patch hover?

@bryevdv

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2019

OK I will push and merge a quick PR for this later today, so I can include these areas in the hatching pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.