New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add "dot" marker variants #9863
Comments
@BenPortner Do you have examples of this in other libraries? cross was added to circle, square, and diamond because the obvious symmetry correspondences. Are you really just wanting to put a + on top of a triangle? If so it might just make sense to make two calls, to |
@bryevdv I don't know if other libraries implement a Of course, one can always plot multiple markers on top of each other. But this is not supported in the |
@BenPortner I can't find any evidence of a triangle cross marker in other libraries:
And I am fairly certain the reason for that is that it would be both visually unappealing due to lack of symmetry, but also not efficacious from a vis standpoint. So I am not inclined to forge new ground here. Personally, I think trying to encode this much into visual marker appearance makes a plot difficult to read and interpret. Setting aside my own opinions, however, we could consider adopting the "dot" variants that plotly shows. Those have an unambiguous application to circle, square, diamond, triangle, and hexagon. Would that be acceptable? (and would you be interested to work on the issue with some guidance/direction?) |
Sure, the |
@BenPortner Here is a recent PR that added support for a hexagon marker (including docs and examples): https://github.com/bokeh/bokeh/pull/7658/files All of the |
@BenPortner I am taking care of this in #9905 |
Very nice @bryevdv!!! Love the new markers. Sorry that I didn't get around to doing it myself. I hope I can contribute something to bokeh in the future because I really love it. Keep up the good work, guys! |
BenPortner commentedApr 1, 2020
Dear bokeh developers,
there are
_cross
versions ofcircle
,square
, anddiamond
. But not fortriangle
. I tried to add atriangle_cross
marker to my plot and got an error. Is there a particular reason for this and if no, could you add it?Keep up the good work!
Ben
The text was updated successfully, but these errors were encountered: