Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure typed arrays are used for storing numerical data #10176

Merged
merged 7 commits into from Jun 16, 2020

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Jun 16, 2020

This is a transitional PR, so existing and a few new hacks will be removed in near future work. This PR ensures that all fields of *Data interfaces are stored as typed arrays whenever applicable (e.g. excluding TextData.text, because there is no typed array for storing strings). This ensures that projections, v_synthetic() and other array to numerical array transforms return typed arrays (type NumberArray = Float64Array to be specific).

@mattpap
Copy link
Contributor Author

mattpap commented Jun 16, 2020

I'm going ahead and merge this as it blocks my other work.

@mattpap mattpap merged commit a7e903a into master Jun 16, 2020
@mattpap mattpap deleted the mattpap/number_arrays branch Jun 16, 2020
@bryevdv bryevdv mentioned this pull request Jul 4, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant