Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require auth on WSHandler #10316

Merged
merged 2 commits into from Jul 27, 2020
Merged

Require auth on WSHandler #10316

merged 2 commits into from Jul 27, 2020

Conversation

philippjfr
Copy link
Contributor

@philippjfr philippjfr commented Jul 16, 2020

Ensures that user authentication occurs before opening the websocket.

  • Add tests

@bryevdv
Copy link
Member

bryevdv commented Jul 27, 2020

OK, I added basic tests to maintain that the views that should use AuthMixin, do so. Not quite as thorough as I would like but we do have extensive tests for AuthMixin itself, so this should be good for now. cc @philippjfr

@philippjfr
Copy link
Contributor Author

philippjfr commented Jul 27, 2020

Thanks! Looks good to me, but would definitely be nice to exercise this properly by starting a server and everything.

@bryevdv
Copy link
Member

bryevdv commented Jul 27, 2020

Hrmm the same win 3.6 webdriver test is suddenly failing in mulitple places. I am going to go ahead and merge this since it's already failing on branch-2.2 and is clearly unrelated. I will see if I can repro the problem on an actual windows machine. cc @philippjfr @mattpap

@bryevdv bryevdv merged commit 5daff21 into branch-2.2 Jul 27, 2020
@bryevdv bryevdv deleted the philippjfr/ws_auth branch Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants