Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented nan_format for other CellFormatters #10416

Merged
merged 3 commits into from Aug 20, 2020

Conversation

philippjfr
Copy link
Contributor

@philippjfr philippjfr commented Aug 20, 2020

Adds nan_format to both ScientificFormatter and DateFormatter after having added it to NumberFormatter in #10375. Also turns DateFormatter into a StringFormatter subclass to expose some of the other string formatting options which are already supported for the Scientific and Date formatters. I'm not sure nan_format is the most accurate on the DateFormatter since technically there shouldn't be NaNs, only nulls and there is no NaT type in JS, but in this case I vote for consistency over precision in the naming.

@bryevdv bryevdv merged commit 5eb625d into branch-2.2 Aug 20, 2020
@bryevdv bryevdv deleted the philippjfr/date_nan_format branch Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants