Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurate color bar ticking with eqhist mapping #10493

Merged
merged 6 commits into from Nov 4, 2020

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Sep 14, 2020

image
image

Early work in progress.

@jbednar
Copy link
Contributor

jbednar commented Sep 14, 2020

Nice. The numerical values really help a viewer get a feel for the distribution of this data, particularly if they think about the fact that each bin has approximately equal numbers of points in it.

@jbednar
Copy link
Contributor

jbednar commented Sep 14, 2020

I take that back; this is a plot of count data, which is integer, so it's not possible for the color bins to have equal numbers of points in them, given how many colors in the colormap are between 0 and 1 (none of which are valid counts). Something is amiss. I'm discussing it with Philipp and Jean-Luc.

@mattpap mattpap force-pushed the mattpap/binned_ticker branch 2 times, most recently from 620efd2 to 268ad3c Compare November 2, 2020 15:27
@mattpap mattpap force-pushed the mattpap/binned_ticker branch 2 times, most recently from ddc12a8 to bacc910 Compare November 2, 2020 23:40
@mattpap
Copy link
Contributor Author

mattpap commented Nov 4, 2020

I'm going ahead and merge this, as it fixes a few issues with bokehjs' tests and is mostly an additive change. This will be refined further when axis labeling is done.

@mattpap mattpap merged commit 7413dac into branch-2.3 Nov 4, 2020
@mattpap mattpap deleted the mattpap/binned_ticker branch November 4, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants