Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recent layout regressions #11123

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Apr 3, 2021

This is more a workaround than a fix, but it seems it works (unless I missed some cases).

fixes #11057

@mattpap
Copy link
Contributor Author

mattpap commented Apr 3, 2021

Marking this as tentatively ready. /cc @philippjfr

@philippjfr
Copy link
Contributor

Thanks will test tomorrow.

@bryevdv
Copy link
Member

bryevdv commented Apr 3, 2021

restarted tests, I think networkx has maybe already sorted their dependency issue.

Edit: evidently not. Also I guess we may need a fix on our end regardless, since who knows when the new package might landin defaults. We will need to either pip install networkx, or lower bound to 2.5.1 to pick it up from conda-forge as soon as it is available there (I'm assuming much sooner then defaults)

@philippjfr
Copy link
Contributor

philippjfr commented Apr 5, 2021

Sorry unrelated but I'm having trouble testing this against Panel since I'm getting this error: Uncaught Error: Cannot find module '../../core/visuals'. I tried building everything back to Bokeh 2.3 and saw the same error so it must be something about my setup and configuration since bokeh 2.3.1dev1 installed from PyPI does work.

@mattpap
Copy link
Contributor Author

mattpap commented Apr 5, 2021

Sorry unrelated but I'm having trouble testing this against Panel since I'm getting this error: Uncaught Error: Cannot find module '../../core/visuals'

@philippjfr, this seems to be a build cache issue (at some point core/visuals were split, which requires a full rebuild). node make build --rebuild or remove the cache (node make clean).

@bryevdv
Copy link
Member

bryevdv commented Apr 6, 2021

confirmed this fixes the issue noted in the docs and examples. I am going to go ahead and merge to try and get 2.3.1rc out tomorrow @philippjfr if you encounter issues w/ panel we can re-open or open new issue as appropriate.

@bryevdv bryevdv merged commit 248a55e into branch-2.3 Apr 6, 2021
@bryevdv bryevdv deleted the mattpap/11057_layout_regressions branch April 6, 2021 00:53
@bryevdv bryevdv added this to the 2.3.1 milestone Apr 6, 2021
bryevdv pushed a commit that referenced this pull request Apr 6, 2021
* Improve viewport computation with sibling elements

* Work around layout's design flaws
bryevdv pushed a commit that referenced this pull request Apr 6, 2021
* Improve viewport computation with sibling elements

* Work around layout's design flaws
bryevdv pushed a commit that referenced this pull request Dec 13, 2021
* Improve viewport computation with sibling elements

* Work around layout's design flaws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants