Fix webgl line NaN handling #11829
Merged
Fix webgl line NaN handling #11829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryevdv
approved these changes
Nov 22, 2021
bryevdv
added
status: accepted
reso: completed
status: ready
and removed
status: ready
status: accepted
labels
|
I didn't have a chance to review this. |
And that's OK. You don't have to be responsible for very single merge. Old and new tests pass, the person who is by far more of an expert at WebGL than either of us is happy with it, the code was completely self-contained to their area of expertise, and it had no obvious other problems. |
bryevdv
pushed a commit
that referenced
this pull request
Dec 13, 2021
* Fix webgl line nan handling * Add baseline images
ianthomas23
added a commit
that referenced
this pull request
May 16, 2022
* Fix webgl line nan handling * Add baseline images
bryevdv
pushed a commit
that referenced
this pull request
May 16, 2022
* Fix webgl line NaN handling (#11829) * Fix webgl line nan handling * Add baseline images * Support multiple marker types in WebGL scatter (#11840) * Support multiple marker types in WebGL scatter * Update macos/windows baseline images * Changes following review * Add docs about different render order * Remove temporary webgl circle fix (#11849) * Add regression test for updating webgl line (#11884) * Add regression test for updating webgl line (issue #8346) * Update macos and windows baseline images * Unify WebGL markers and rects (#12040) * Unify markers and rects * Baseline images * Consistent code style * WebGL typescript refactor and add quad glyph (#12046) * SingleMarkerGL for rect and quad * MarkerGL inherits from BaseMarkerGL * Better class hierarchy * Test WebGL quad glyph * Separate CircleGL class * Avoid use of any * Remove code duplication * Implement WebGL marker line joins (#12055) * Line joins for markers * Use same antialiasing width for all webgl markers * Correct size hints * Baseline image changes * Marker glyph should support line join test * WebGL support for HBar VBar and HexTile glyphs (#12061) * Add WebGL HBar and VBar glyphs * Add WebGL HexTile glyphs * Visual test changes * Include rotation in should_support_Rect test * Minor WebGL line refactor (#12120) * Fix Wedge and AnnualWedge glyph hitboxes (#12071) * Fix Wedge and AnnualWedge glyph hitboxes * Hitbox tests for Wedge and AnnualWedge glyphs Co-authored-by: Michael Brown <michael@msbrown.net>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 8th item of issue #11050.
The previous WebGL solution for NaNs in lines wasn't good enough. NaNs are not suitable for use in WebGL shaders due to their reduced floating-point precision, so the previous solution used a large negative number to represent NaNs. This worked for many use cases but not for
x, yvalues near that large negative number or when zooming in by many orders of magnitude. This solution uses a newshowarray to indicate which segments should be shown, and is similar to the WebGL rect/marker handling ofindices.There are already a couple of visual tests for NaNs in WebGL lines. I have added a new one that shows the bug before this fix and the correct solution after this fix.
Before:
After:
