WebGL typescript refactor and add quad glyph #12046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
force-pushed
the
ianthomas23/webgl_quad
branch
from
dbc6af3
to
fbbd976
Compare
|
On further consideration, let's keep the different antialiasing width as it is here. I need to write a PR fixing the different line joins for WebGL markers and that will change quite a few WebGL marker baseline images, so I can correct the antialiasing width at the same time. I'll do that in the next few weeks. |
bryevdv
reviewed
Mar 16, 2022
I suppose it isn't a very visible difference? If so, we can safely wait for another batch of changes. |
Yes, it is just the antialiased edge pixels that have slightly different intensities. |
ianthomas23
added a commit
that referenced
this pull request
May 16, 2022
* SingleMarkerGL for rect and quad * MarkerGL inherits from BaseMarkerGL * Better class hierarchy * Test WebGL quad glyph * Separate CircleGL class * Avoid use of any * Remove code duplication
bryevdv
pushed a commit
that referenced
this pull request
May 16, 2022
* Fix webgl line NaN handling (#11829) * Fix webgl line nan handling * Add baseline images * Support multiple marker types in WebGL scatter (#11840) * Support multiple marker types in WebGL scatter * Update macos/windows baseline images * Changes following review * Add docs about different render order * Remove temporary webgl circle fix (#11849) * Add regression test for updating webgl line (#11884) * Add regression test for updating webgl line (issue #8346) * Update macos and windows baseline images * Unify WebGL markers and rects (#12040) * Unify markers and rects * Baseline images * Consistent code style * WebGL typescript refactor and add quad glyph (#12046) * SingleMarkerGL for rect and quad * MarkerGL inherits from BaseMarkerGL * Better class hierarchy * Test WebGL quad glyph * Separate CircleGL class * Avoid use of any * Remove code duplication * Implement WebGL marker line joins (#12055) * Line joins for markers * Use same antialiasing width for all webgl markers * Correct size hints * Baseline image changes * Marker glyph should support line join test * WebGL support for HBar VBar and HexTile glyphs (#12061) * Add WebGL HBar and VBar glyphs * Add WebGL HexTile glyphs * Visual test changes * Include rotation in should_support_Rect test * Minor WebGL line refactor (#12120) * Fix Wedge and AnnualWedge glyph hitboxes (#12071) * Fix Wedge and AnnualWedge glyph hitboxes * Hitbox tests for Wedge and AnnualWedge glyphs Co-authored-by: Michael Brown <michael@msbrown.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the WebGL shader refactor for markers (#12040), this PR refactors the typescript for WebGL markers (and other fixed-shaped glyphs) and adds a WebGL
quadglyph. Class hierarchy is nowFor markers, including rect, circle, etc, there is now only a single place where the ReGL draw functions are called, and only a single place where the line/fill/hatch visuals are setup for WebGL. The concrete marker classes just set the locations (center, width, height and angles) of the WebGL glyphs.
I have added a new
quadglyph to show this works in ~60 lines of typescript, and extended the existing quad visual test to include WebGL; you can tell it is not just a copy of the canvas rendering by the slightly different antialiased corner pixels.I have also put WebGL circle in its own class rather than sharing what is now called the
MultiMarkerGLclass which makes the latter easier to understand.One thing I have noticed is that the antialiasing width is different for
scattermarkers than forrect, etc and they should really be the same. This is historical and I should have fix it them #12040. I have kept them different for the moment as to make them the same will change many WebGL visual baseline images. There are 2 options for dealing with this:I am happy to accept advice on this.
Following on from this it will be easy to add
Hbar,VbarandHexTileWebGL glyphs.This work is part of the CZI round 3 extension.