WebGL support for HBar VBar and HexTile glyphs #12061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
commented
Mar 25, 2022
|
|
||
| if (this.glyph.model.orientation == "pointytop") { | ||
| this._angles!.set_from_scalar(0.5*Math.PI) | ||
| this._widths!.set_from_scalar(this.glyph.svy[0]*2) |
There was a problem hiding this comment.
Widths and heights are taken from HexTileView.svx and svy which are calculated in _get_unscaled_vertices(). I thought this better than recalculating the sizes here as well, although looking in the svx and svy arrays is not ideal.
|
@ianthomas23 this is great, my only comment is that rects do support rotation about their center, so perhaps the |
|
Added rotation |
ianthomas23
added a commit
that referenced
this pull request
May 16, 2022
* Add WebGL HBar and VBar glyphs * Add WebGL HexTile glyphs * Visual test changes * Include rotation in should_support_Rect test
bryevdv
pushed a commit
that referenced
this pull request
May 16, 2022
* Fix webgl line NaN handling (#11829) * Fix webgl line nan handling * Add baseline images * Support multiple marker types in WebGL scatter (#11840) * Support multiple marker types in WebGL scatter * Update macos/windows baseline images * Changes following review * Add docs about different render order * Remove temporary webgl circle fix (#11849) * Add regression test for updating webgl line (#11884) * Add regression test for updating webgl line (issue #8346) * Update macos and windows baseline images * Unify WebGL markers and rects (#12040) * Unify markers and rects * Baseline images * Consistent code style * WebGL typescript refactor and add quad glyph (#12046) * SingleMarkerGL for rect and quad * MarkerGL inherits from BaseMarkerGL * Better class hierarchy * Test WebGL quad glyph * Separate CircleGL class * Avoid use of any * Remove code duplication * Implement WebGL marker line joins (#12055) * Line joins for markers * Use same antialiasing width for all webgl markers * Correct size hints * Baseline image changes * Marker glyph should support line join test * WebGL support for HBar VBar and HexTile glyphs (#12061) * Add WebGL HBar and VBar glyphs * Add WebGL HexTile glyphs * Visual test changes * Include rotation in should_support_Rect test * Minor WebGL line refactor (#12120) * Fix Wedge and AnnualWedge glyph hitboxes (#12071) * Fix Wedge and AnnualWedge glyph hitboxes * Hitbox tests for Wedge and AnnualWedge glyphs Co-authored-by: Michael Brown <michael@msbrown.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for WebGL rendering of
HBar,VBarandHexTileglyphs.HBarandVBaruseQuadGLalmost without any changes, so I have renamedQuadGLtoLRTBGLas all 3GlyphViews use the same left, right, top and bottom properties.Most of the changes to support
HexTileGLare to change the WebGL fragment shader to support hex glyphs of varying aspect ratio rather than the fixed aspect ratio thatscatter(marker='hex', ...)uses.I have extended the existing visual tests to include WebGL testing for those glyphs that we support so far, which includes
circleandrectfor completeness. There are quite a few visual tests forhex_tileand I have only altered the two that include hatch patterns as this is the easiest way to identify WebGL rendering vs canvas or SVG. Here is one of them:This work is part of the CZI round 3 extension.