Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #12720

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Drop support for Python 3.8 #12720

merged 1 commit into from
Mar 13, 2023

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Jan 6, 2023

This is about two weeks earlier than BEP 9 stipulates, but it will be fulfilled by the time 3.1 is released. In the meantime, this will reduce CI test time by a considerable margin (testing another Python version is about 50~60 minutes cumulative).

@mattpap mattpap added status: ready type: task tag: codebase Improvements to code quality without affecting any functionality. labels Jan 6, 2023
@mattpap mattpap added this to the 3.1 milestone Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #12720 (c9e6b01) into branch-3.2 (5a83445) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.2   #12720   +/-   ##
===========================================
  Coverage       92.36%   92.36%           
===========================================
  Files             315      315           
  Lines           19962    19962           
===========================================
  Hits            18437    18437           
  Misses           1525     1525           

@bryevdv
Copy link
Member

bryevdv commented Jan 6, 2023

It does not make sense to me to drop support right before a minor release. If the release is imminent, then we can just endure the short wait, to give users the benefit of increased options, and remove right after the release.

cc @bokeh/core

@philippjfr
Copy link
Contributor

I'm +1 on waiting until after 3.1. With my Panel hat on I'd prefer to support Python 3.7 in Panel 1.0 and then drop it immediately thereafter and since Panel 1.0 will pin to bokeh 3.1 that would make it impossible.

@mattpap mattpap modified the milestones: 3.1, 3.2 Jan 6, 2023
@mattpap mattpap force-pushed the mattpap/drop_python_3.8 branch from 3fa9999 to 0d4f100 Compare January 8, 2023 12:19
@mattpap mattpap changed the base branch from branch-3.1 to branch-3.2 March 4, 2023 15:48
@mattpap mattpap force-pushed the mattpap/drop_python_3.8 branch 2 times, most recently from 66d40cf to aedad6e Compare March 5, 2023 17:10
@mattpap mattpap force-pushed the mattpap/drop_python_3.8 branch from aedad6e to c9e6b01 Compare March 13, 2023 10:07
@mattpap mattpap merged commit 3416314 into branch-3.2 Mar 13, 2023
@mattpap mattpap deleted the mattpap/drop_python_3.8 branch March 13, 2023 11:17
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
reso: completed status: accepted tag: codebase Improvements to code quality without affecting any functionality. type: task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants