Add support for editable `Label` annotation by mattpap · Pull Request #12825 · bokeh/bokeh

mattpap · 2023-02-20T11:44:10Z

This continues the work done in PR #12468. This PR adds support for editing (~~moving~~ and especially rotating) Label annotations. It also adds feature parity with Text glyph, i.e. adds support for padding and rounded corners (this includes Title annotation).

Title with padding=10, border_radius=8 and line styling:

Rotation of Label with editable=True:

Screencast_00005.mp4

fixes Add support Title/Label bounding box padding #4416

codecov · 2023-02-20T12:05:27Z

Codecov Report

Merging #12825 (b42b884) into branch-3.4 (99d19b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           branch-3.4   #12825   +/-   ##
===========================================
  Coverage       92.64%   92.65%           
===========================================
  Files             321      321           
  Lines           20415    20428   +13     
===========================================
+ Hits            18914    18927   +13     
  Misses           1501     1501

mattpap · 2023-10-12T09:43:55Z

Note that this PR only implements rotation under editable=True. Movement is already implemented in BoxAnnotation, thus this needs to be generalized and implemented once for all box-like annotations, which I will do in another PR.

bryevdv · 2023-11-07T19:07:12Z

@mattpap looks like some SVG issues, are these related to any known open SVG issues or if not should there be new ones opened?

bryevdv · 2023-11-07T19:09:37Z

src/bokeh/models/annotations/labels.py

+        This property is experimental and may change at any point.
+    """)
+
+    editable = Bool(default=False, help="""


Would rotatable be better / more specific? When I opened this PR and saw "editable" I first thought this was a about editing the text of the labels

This indeed may be confusing for labels, but is consistent with other APIs. All APIs broadly related to editability are experimental, so we can iterate over the design. Perhaps a better choice would have been interactive, but if we decide so, then this will have to be applied consistently. I will leave this for now. There will be more changes like this one in near future, specifically text editability of Text glyph and Label, so will have a better picture then.

src/bokeh/models/annotations/labels.py

mattpap · 2023-11-07T19:35:17Z

looks like some SVG issues, are these related to any known open SVG issues or if not should there be new ones opened?

It's a "known issue" related drawing arcs on SVG canvas, but I don't see any open issue for that. I will open one.

bryevdv

Minor comments, LGTM

mattpap · 2023-11-08T12:19:50Z

Actually there is an issue for broken ctx.arcTo() in SVG canvas (#12699).

* Clean up the implementation of Label annotation * Add support for anchor/padding to Label * Add support for editable Label rotation * Add support for border radius * Connect compute_geometry() * Support node resolution in Label * Update examples/basic/annotations/label.py * Update defaults' baseline * Resolve issues with positioning math text labels * Generalize the implementation for Title * Unify layout and get_size() handling * Include padding in get_size() computation * Robustify unit tests * Add visual tests for Title * Add visual tests for Label * Partially update HTML* variants * Add release notes * Update visual baselines

github-actions · 2024-10-25T19:09:59Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

mattpap added type: feature status: WIP labels Feb 20, 2023

mattpap added this to the 3.2 milestone Feb 20, 2023

mattpap force-pushed the mattpap/editable_label branch from 1bf1454 to 8fafa06 Compare February 20, 2023 15:40

mattpap changed the base branch from branch-3.1 to branch-3.2 March 4, 2023 15:47

mattpap force-pushed the mattpap/editable_label branch from 8fafa06 to 1a28567 Compare May 21, 2023 17:58

mattpap modified the milestones: 3.2, 3.3 May 23, 2023

mattpap changed the base branch from branch-3.2 to branch-3.3 June 15, 2023 07:50

mattpap force-pushed the mattpap/editable_label branch from 1a28567 to 7e6f20a Compare September 15, 2023 19:13

mattpap modified the milestones: 3.3, 3.4 Oct 4, 2023

mattpap changed the base branch from branch-3.3 to branch-3.4 October 10, 2023 12:49

mattpap force-pushed the mattpap/editable_label branch from 7e6f20a to 7e4cbc4 Compare October 11, 2023 10:16

mattpap added status: ready and removed status: WIP type: feature labels Oct 12, 2023

mattpap mentioned this pull request Oct 19, 2023

Use curly brackets in bokehjs for all statements #13449

Merged

mattpap force-pushed the mattpap/editable_label branch from 5a0b0cb to 409c8cd Compare October 30, 2023 21:20

bryevdv reviewed Nov 7, 2023

View reviewed changes

src/bokeh/models/annotations/labels.py Outdated Show resolved Hide resolved

bryevdv approved these changes Nov 7, 2023

View reviewed changes

mattpap added 4 commits November 8, 2023 13:17

Clean up the implementation of Label annotation

fd5e638

Add support for anchor/padding to Label

99464ed

Add support for editable Label rotation

6acf1c7

Add support for border radius

25758fe

mattpap added 14 commits November 8, 2023 13:17

Connect compute_geometry()

805269b

Support node resolution in Label

f637ee3

Update examples/basic/annotations/label.py

9426b42

Update defaults' baseline

68f3327

Resolve issues with positioning math text labels

84f1de3

Generalize the implementation for Title

376d3c0

Unify layout and get_size() handling

5f8e18f

Include padding in get_size() computation

29db2e0

Robustify unit tests

5a2ef1d

Add visual tests for Title

06cd2fa

Add visual tests for Label

be69d4c

Partially update HTML* variants

a33f6c6

Add release notes

32e33f3

Update visual baselines

b42b884

mattpap force-pushed the mattpap/editable_label branch from 409c8cd to b42b884 Compare November 8, 2023 12:18

mattpap added status: accepted and removed status: ready labels Nov 8, 2023

mattpap merged commit 5108e25 into branch-3.4 Nov 8, 2023

mattpap deleted the mattpap/editable_label branch November 8, 2023 14:06

github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for editable `Label` annotation#12825

Add support for editable `Label` annotation#12825
mattpap merged 18 commits intobranch-3.4from
mattpap/editable_label

mattpap commented Feb 20, 2023 •

edited

Loading

Uh oh!

codecov bot commented Feb 20, 2023 •

edited

Loading

Uh oh!

mattpap commented Oct 12, 2023

Uh oh!

bryevdv commented Nov 7, 2023

Uh oh!

bryevdv Nov 7, 2023

Uh oh!

mattpap Nov 8, 2023

Uh oh!

Uh oh!

mattpap commented Nov 7, 2023

Uh oh!

bryevdv left a comment

Uh oh!

mattpap commented Nov 8, 2023

Uh oh!

github-actions bot commented Oct 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mattpap commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mattpap commented Oct 12, 2023

Uh oh!

bryevdv commented Nov 7, 2023

Uh oh!

bryevdv Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

mattpap Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattpap commented Nov 7, 2023

Uh oh!

bryevdv left a comment

Choose a reason for hiding this comment

Uh oh!

mattpap commented Nov 8, 2023

Uh oh!

github-actions bot commented Oct 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mattpap commented Feb 20, 2023 •

edited

Loading

codecov bot commented Feb 20, 2023 •

edited

Loading