Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make autocompleteinput.py example work with Pandas 2.0 #13057

Merged
merged 1 commit into from Apr 5, 2023
Merged

Make autocompleteinput.py example work with Pandas 2.0 #13057

merged 1 commit into from Apr 5, 2023
+1 −1

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Apr 5, 2023

fixes #13056

@mattpap mattpap added this to the 3.2 milestone Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023 •
edited

Codecov Report

Merging #13057 (12ebb56) into branch-3.2 (865dda8) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.2   #13057   +/-   ##
===========================================
  Coverage       92.35%   92.35%           
===========================================
  Files             315      315           
  Lines           19969    19969           
===========================================
  Hits            18443    18443           
  Misses           1526     1526

@mattpap
Copy link
Contributor Author

mattpap commented Apr 5, 2023

I will go ahead and merge this to unblock CI.

@mattpap mattpap merged commit 4c6f734 into branch-3.2 Apr 5, 2023
27 checks passed
@mattpap mattpap deleted the mattpap/13056_autocomplete_pandas_2.0 branch April 5, 2023 12:23
@graingert
Copy link
Contributor

this is a legitimate city called None https://goo.gl/maps/mmMWgdGpm4UvKCWm7 might be better to tell pandas this is a string column

@graingert graingert mentioned this pull request Apr 6, 2023
Closed
3 tasks
@mattpap
Copy link
Contributor Author

mattpap commented Apr 6, 2023

That would be a better fix indeed There are a few more https://geotargit.com/called.php?qcity=None.

@graingert graingert mentioned this pull request Apr 6, 2023
Open
graingert added a commit to graingert/bokeh that referenced this pull request Apr 6, 2023
@graingert
Revert "Make autocompleteinput.py example work with Pandas 2.0 (bokeh…
6537953 
…#13057)"

This reverts commit 4c6f734.
@graingert
Copy link
Contributor

@mattpap fixed in #13069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

autocompleteinput.py example doesn't work with pandas 2.0
2 participants
@mattpap @graingert