Allow to configure and report key modifiers in TapTool and pointer events#13132
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-3.2 #13132 +/- ##
===========================================
Coverage 92.41% 92.41%
===========================================
Files 315 315
Lines 20029 20038 +9
===========================================
+ Hits 18509 18518 +9
Misses 1520 1520 |
mattpap
force-pushed
the
mattpap/12532_TapTool_modifiers
branch
from
May 21, 2023 12:01
b6b30af to
1cda558
Compare
mattpap
force-pushed
the
mattpap/12532_TapTool_modifiers
branch
from
May 21, 2023 12:25
1cda558 to
a7a62e9
Compare
bryevdv
approved these changes
May 23, 2023
bryevdv
left a comment
bryevdv
left a comment
Member
There was a problem hiding this comment.
LGTM modulo two small suggestions
mattpap
force-pushed
the
mattpap/12532_TapTool_modifiers
branch
from
May 23, 2023 19:43
a7a62e9 to
2bb4d76
Compare
|
but this still only allows for a single action per each TapTool, right? |
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
…events (bokeh#13132) * Allow to configure key modifiers in TapTool * Refactor callback emit in TapTool * Expose key modifiers to the callback in inspect mode * Expose key modifiers to pointer events * Add an example of inspect setup of TapTool * Unify handling of key modifiers across bokehjs * Add unit tests for setting modifiers and reporting * Added a release note * Rename tap_inspect.py -> tap_inspect_keymod.py * Change a note to a warning
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two things:
TapToolwith key modifiers required to trigger the tool. This is specifically useful ininspectmode, less inselectmode, which has intrinsic meaning for key modifiers, derived from other select tools.TapTool's callback data and allows the same for pointer eventsTap, etc.fixes #12532