Skip to content

13211 allow inline math text#13214

Merged
mattpap merged 8 commits into
bokeh:branch-3.3from
mosc9575:13211_allow_inline_math_text
Sep 4, 2023
Merged

13211 allow inline math text#13214
mattpap merged 8 commits into
bokeh:branch-3.3from
mosc9575:13211_allow_inline_math_text

Conversation

@mosc9575

@mosc9575 mosc9575 commented Jun 17, 2023

Copy link
Copy Markdown
Contributor

This is the initial version to allow inline math text. The visual appearance is not touched. The main idea is to add the workaround \text{...} to any not math section in a string which contains math.

Kindly asking for some feedback.

@codecov

codecov Bot commented Jun 17, 2023

Copy link
Copy Markdown

Codecov Report

Merging #13214 (c05ce5a) into branch-3.3 (310cb2c) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           branch-3.3   #13214   +/-   ##
===========================================
  Coverage       92.45%   92.45%           
===========================================
  Files             315      315           
  Lines           20169    20169           
===========================================
  Hits            18647    18647           
  Misses           1522     1522           

@mattpap mattpap force-pushed the 13211_allow_inline_math_text branch from 5795c2e to c05ce5a Compare August 31, 2023 13:25
@mattpap mattpap added this to the 3.3 milestone Aug 31, 2023
@mattpap

mattpap commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

@mosc9575, thanks for the initial implementation. I fixed the remaining issues and refactored the implementation.

@ianthomas23 ianthomas23 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Thanks both @mosc9575 and @mattpap.

@mattpap mattpap merged commit 3348f65 into bokeh:branch-3.3 Sep 4, 2023
@mosc9575 mosc9575 deleted the 13211_allow_inline_math_text branch September 26, 2023 18:30
Chiemezuo pushed a commit to Chiemezuo/bokeh that referenced this pull request Aug 27, 2024
* add math inline support

* adapt examples and tests and add metainformation

* fixing lint issues

* "add missing whitespace"

* Refactor and improve the implementation

* support multi-line strings
* restore `inline: true`

* Update unit tests

* Use structural equality in unit tests

* Add release notes

---------

Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow inline LaTeX support

3 participants