13211 allow inline math text #13214
Merged
13211 allow inline math text #13214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-3.3 #13214 +/- ##
===========================================
Coverage 92.45% 92.45%
===========================================
Files 315 315
Lines 20169 20169
===========================================
Hits 18647 18647
Misses 1522 1522 |
"add missing whitespace"
* support multi-line strings * restore `inline: true`
mattpap
force-pushed
the
13211_allow_inline_math_text
branch
from
5795c2e to
c05ce5a
Compare
|
@mosc9575, thanks for the initial implementation. I fixed the remaining issues and refactored the implementation. |
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
* add math inline support * adapt examples and tests and add metainformation * fixing lint issues * "add missing whitespace" * Refactor and improve the implementation * support multi-line strings * restore `inline: true` * Update unit tests * Use structural equality in unit tests * Add release notes --------- Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial version to allow inline math text. The visual appearance is not touched. The main idea is to add the workaround
\text{...}to any not math section in a string which contains math.Kindly asking for some feedback.