Add support for poly hit testing to Patches and greedy mode - #13277
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-3.3 #13277 +/- ##
===========================================
Coverage 92.43% 92.43%
===========================================
Files 316 316
Lines 20218 20221 +3
===========================================
+ Hits 18688 18691 +3
Misses 1530 1530 |
Contributor
Author
|
I inverted the meaning of greedy selection, to match the proposal in issue #2325 (the screencast is not updated). |
mattpap
changed the title
Patches and non-greedy modePatches and greedy mode
mattpap
force-pushed
the
mattpap/2325_Patches_poly_hit_test
branch
from
September 12, 2023 10:13
6d4345e to
ad98e6c
Compare
mattpap
force-pushed
the
mattpap/2325_Patches_poly_hit_test
branch
from
September 15, 2023 18:39
ad98e6c to
1adaa99
Compare
ianthomas23
approved these changes
Sep 19, 2023
ianthomas23
left a comment
ianthomas23
left a comment
Member
There was a problem hiding this comment.
The example is really nice!
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
…13277) * Add poly hit testing to Patches glyph * Add support for non-greedy region selection * Implement Patches._hit_rect in terms of _hit_poly * Invert the meaning of greedy selection * Use spatial index in MarkerView._hit_poly() * Use minmax2(xs, ys) instead of minmax(xs) and minmax(ys) * Add support for MultiPolygons._hit_poly and greedy selections * Increase timeout in devtools' server * Add release notes * Use ndarrays for lats and lons in us_{counties,states}.py * Add unit tests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for poly hit testing to
PatchesandMultiPolygons. It also makes hit testing procedures to use spatial index where they previously didn't and generally refactors/modernizes hit testing code.Screencast_00001.mp4
fixes #2325